Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/line numbers #56

Merged
merged 2 commits into from
Apr 12, 2018
Merged

Feature/line numbers #56

merged 2 commits into from
Apr 12, 2018

Conversation

dbfannin
Copy link
Owner

This will support logging file name and line number where the logger was called. This also creates a static logger utils class.

@dbfannin dbfannin mentioned this pull request Apr 10, 2018
@dbfannin dbfannin requested a review from joshuakmurphy April 10, 2018 13:50
@dbfannin dbfannin self-assigned this Apr 10, 2018
Copy link

@joshuakmurphy joshuakmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this!

@dbfannin dbfannin merged commit ad67193 into master Apr 12, 2018
@dbfannin dbfannin deleted the feature/lineNumbers branch April 30, 2018 14:58
@mreddy13
Copy link

Hi, I am facing some issue with logging line number, I am using latest version, I followed steps in npm repo to install and use them, when I am logging them in console the line number is different than exact one. PFA for images. Please let me know if I am doing something wrong or do I need to change something.
image
image

@abney317
Copy link

@dbfannin I'm seeing "vendor.js" in all of my log statements instead of the component file I'd expect.

(top is from console.log)
image

@dbfannin
Copy link
Owner Author

@abney317, please see #69. When angular 6 came out they change the way compilation work and no longer compile node modules along with the app. We're aware of the issue and trying to think of a good solution to solve it. If you had any ideas, we'd love to hear about them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants