Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for discord-botlist.eu #318

Merged
merged 4 commits into from
Sep 17, 2021
Merged

Added support for discord-botlist.eu #318

merged 4 commits into from
Sep 17, 2021

Conversation

LPTP1Dev
Copy link
Contributor

Hey,
I added support for discord-botlist.eu since we re-wrote our api and we are no longer using websocket for stats posting.

Greetings
LPTP1
Founder of Discord-Botlist.EU

@EndBug EndBug added the type: feature New feature or feature request label Sep 16, 2021
@EndBug EndBug self-assigned this Sep 16, 2021
Copy link
Member

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you so much for your contribution!
Just one thing: could you run npm run build:source so that the ListIndex gets updated? Currently, some tests are failing because the list is out of date.
You can check if the test pass by running npm test ;)

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #318 (99d12f0) into master (5b7c9de) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   97.59%   97.63%   +0.04%     
==========================================
  Files          41       42       +1     
  Lines        1162     1182      +20     
  Branches      189      189              
==========================================
+ Hits         1134     1154      +20     
  Misses         27       27              
  Partials        1        1              
Impacted Files Coverage Δ
src/Interface/ListIndex.ts 100.00% <100.00%> (ø)
src/Interface/Lists/DiscordBotlistEU.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b7c9de...99d12f0. Read the comment docs.

Copy link
Member

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@EndBug EndBug merged commit cf2eec1 into dbots-pkg:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants