Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discord-botlist.eu #319

Merged
merged 5 commits into from
Sep 18, 2021
Merged

Improve discord-botlist.eu #319

merged 5 commits into from
Sep 18, 2021

Conversation

EndBug
Copy link
Member

@EndBug EndBug commented Sep 17, 2021

I've improved on the discord-botlist.eu class added in #318:

  • Endpoints now use the Bearer token format
  • Ping and Analytics endpoitns have been added

These changes come not from the official docs, but from the official library: npm, GitHub

@Snazzah could you give it a look before we publish it?

@EndBug EndBug added the type: feature New feature or feature request label Sep 17, 2021
@EndBug EndBug requested a review from Snazzah September 17, 2021 18:06
@EndBug EndBug self-assigned this Sep 17, 2021
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #319 (4ba75d7) into master (cf2eec1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #319   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          42       42           
  Lines        1182     1186    +4     
  Branches      189      189           
=======================================
+ Hits         1154     1158    +4     
  Misses         27       27           
  Partials        1        1           
Impacted Files Coverage Δ
src/Interface/Lists/DiscordBotlistEU.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca02388...4ba75d7. Read the comment docs.

@EndBug EndBug merged commit 0d37c81 into master Sep 18, 2021
@EndBug EndBug deleted the dbleu branch September 18, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants