Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added call to defer_to_manifest in before_run step for compile / docs… #6188

Closed
wants to merge 2 commits into from
Closed

Added call to defer_to_manifest in before_run step for compile / docs… #6188

wants to merge 2 commits into from

Conversation

seub
Copy link
Contributor

@seub seub commented Nov 1, 2022

… generate

resolves #

Description

Checklist

@seub seub requested review from a team and ChenyuLInx November 1, 2022 16:01
@cla-bot cla-bot bot added the cla:yes label Nov 1, 2022
@seub seub requested a review from a team as a code owner November 1, 2022 16:01
@seub seub requested a review from VersusFacit November 1, 2022 16:01
@ChenyuLInx
Copy link
Contributor

@seub Thanks for putting up the PR! Do you feel comfortable trying to add some tests for this usecase?
@jtcohen6 looks like this one will generate the docs based on the combination of deferred manifest and current project, is this a feature we want to add.

@jtcohen6 jtcohen6 added ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering Team:Execution labels Nov 22, 2022
@jtcohen6
Copy link
Contributor

I think the implementation here is based on my comment in #6124 (comment) - good to go from my point of view

@seub
Copy link
Contributor Author

seub commented Nov 24, 2022

Thanks @ChenyuLInx and @jtcohen6. I was excited to contribute to dbt but after trying to follow all the steps of the contributing guide I think I got discouraged by all the failing tests (I think it was make integration on my end?). I don't think these failures have anything to do with the diff I introduced and I didn't want to spend more time investigating. I also would need to invest more time trying to understand how to add new tests.

Long story short, I appreciate the incitement to contribute, and I tried, but the entry ticket is a bit steep for me. I'll have to leave it to your expert hands and hopefully try again to contribute in the future.

@jtcohen6 jtcohen6 linked an issue Dec 6, 2022 that may be closed by this pull request
2 tasks
@jtcohen6
Copy link
Contributor

jtcohen6 commented Jan 2, 2023

Thanks for taking a stab at it @seub! Closing in favor of the newer PR: #6488

@jtcohen6 jtcohen6 closed this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1386] [Bug] dbt docs generate with --defer
3 participants