Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add defer_to_manifest in before_run to fix faulty deferred docs generate #6488

Merged
merged 4 commits into from
Jan 10, 2023
Merged

add defer_to_manifest in before_run to fix faulty deferred docs generate #6488

merged 4 commits into from
Jan 10, 2023

Conversation

mivanicova
Copy link
Contributor

@mivanicova mivanicova commented Dec 26, 2022 •
edited
Loading

resolves #6124

Description

The dbt docs generate --defer command does not work as expected as it ignores the state. This PR fixes the issue by:

  • adding call to defer_to_manifest to before_run of compile/docs generate
  • extending integration tests to validate that the generated catalog is indeed coming from the deferred state

Checklist

@mivanicova mivanicova requested a review from a team December 26, 2022 00:01
@mivanicova mivanicova requested a review from a team as a code owner December 26, 2022 00:01
@cla-bot cla-bot bot added the cla:yes label Dec 26, 2022
@mivanicova mivanicova changed the title WIP: add defer_to_manifest in before_run to fix faulty deferred docs generate add defer_to_manifest in before_run to fix faulty deferred docs generate Dec 26, 2022
@mivanicova mivanicova mentioned this pull request Dec 26, 2022
Closed
2 tasks
@jtcohen6 jtcohen6 mentioned this pull request Jan 2, 2023
Closed
6 tasks
@jtcohen6 jtcohen6 added Team:Execution ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering labels Jan 2, 2023
ChenyuLInx
ChenyuLInx approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mivanicova Thanks for adding this fix and adding the base function! Validated that removing the line would make the test fail.

@ChenyuLInx ChenyuLInx merged commit 0fc080d into dbt-labs:main Jan 10, 2023
@mivanicova mivanicova deleted the fix-defer-for-docs-generate branch January 11, 2023 12:50
@jtcohen6 jtcohen6 mentioned this pull request Jan 12, 2023
Merged
@jtcohen6 jtcohen6 mentioned this pull request Jan 22, 2023
Merged
6 tasks
@iknox-fa iknox-fa mentioned this pull request Jan 30, 2023
Closed
6 tasks
@dbeatty10 dbeatty10 mentioned this pull request Dec 6, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@iknox-fa iknox-fa Awaiting requested review from iknox-fa

@colin-rogers-dbt colin-rogers-dbt Awaiting requested review from colin-rogers-dbt colin-rogers-dbt was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1386] [Bug] dbt docs generate with --defer
3 participants
@mivanicova @ChenyuLInx @jtcohen6