gcs: Support empty filters. #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
gcs_allow_empty_filters
branch
2 times, most recently
from
a0b8422 to
87bf1ab
Compare
This was referenced Aug 20, 2019
dajohi
approved these changes
Aug 20, 2019
jrick
approved these changes
Aug 20, 2019
matheusd
approved these changes
Aug 20, 2019
This adds support for empty filters versus being an error along with a full set of tests to ensure the empty filter works as intended. It is part of the onging process to cleanup and improve the gcs module to the quality level required by consensus code for ultimate inclusion in header commitments.
davecgh
force-pushed
the
gcs_allow_empty_filters
branch
from
87bf1ab to
468f328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PR #1843.
This adds support for empty filters versus being an error along with a full set of tests to ensure the empty filter works as intended.
It is part of the onging process to cleanup and improve the
gcsmodule to the quality level required by consensus code for ultimate inclusion in header commitments.