-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcs: Overhaul tests and benchmarks. #1845
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that no coverage was added for |
dajohi
approved these changes
Aug 20, 2019
jrick
approved these changes
Aug 20, 2019
matheusd
approved these changes
Aug 20, 2019
davecgh
commented
Aug 20, 2019
davecgh
force-pushed
the
gcs_rework_tests
branch
from
August 20, 2019 14:33
55a9d1b
to
f7f73ce
Compare
This rewrites the tests to make them more consistent with the rest of the code base and significantly increases their coverage of the code. It also reworks the benchmarks to actually benchmark what their names claim, renames them for consistency, and make them more stable by ensuring the same prng seed is used each run to eliminate variance introduced by different values. Finally, it removes an impossible to hit condition from the bit reader and adds a couple of additional checks to harden the filters against potential misuse. This is part of the ongoing process to cleanup and improve the gcs module to the quality level required by consensus code for ultimate inclusion in header commitments.
davecgh
force-pushed
the
gcs_rework_tests
branch
from
August 20, 2019 14:36
f7f73ce
to
2a8856d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PRs #1843 and #1844.
This rewrites the tests to make them more consistent with the rest of the code base and significantly increases their coverage of the code.
It also reworks the benchmarks to actually benchmark what their names claim, renames them for consistency, and make them more stable by ensuring the same prng seed is used each run to eliminate variance introduced by different values.
Finally, it removes an impossible to hit condition from the bit reader and adds a couple of additional checks to harden the filters against potential misuse.
This is part of the ongoing process to cleanup and improve the
gcs
module to the quality level required by consensus code for ultimate inclusion in header commitments.