Skip to content
This repository was archived by the owner on Nov 3, 2022. It is now read-only.

Do not use and overwrite public labels for appearance status #543

Closed
5 tasks done
bonndan opened this issue May 24, 2021 · 0 comments · Fixed by #638
Closed
5 tasks done

Do not use and overwrite public labels for appearance status #543

bonndan opened this issue May 24, 2021 · 0 comments · Fixed by #638
Labels
cleanup java Pull requests that update Java code S T-Shirt size for estimation.

Comments

@bonndan
Copy link
Collaborator

bonndan commented May 24, 2021

The labels Label.icon, Label.fill, Label.color are overwritten by the AppearanceProcessor. Changes would appear in the changelog and also user input would be overwritten.

  • color can be set by appearance processor if null / empty
  • icon and fill must not be overwritten. Instead introduce labels "renderedIcon" and "renderedFill".
  • check if getIcon() should remain in the component interface
  • use rendered* in svg/map generation
  • make sure the changes do not appear in the changelog
@bonndan bonndan added cleanup java Pull requests that update Java code S T-Shirt size for estimation. labels May 24, 2021
@bonndan bonndan mentioned this issue Jul 2, 2021
7 tasks
bonndan pushed a commit that referenced this issue Aug 8, 2021
[#543] introduced ApiModels, internal labels
@bonndan bonndan mentioned this issue Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cleanup java Pull requests that update Java code S T-Shirt size for estimation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant