Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hand-wrap the Table class in Python #1486

Closed
Tracked by #1263
jmao-denver opened this issue Oct 26, 2021 · 0 comments · Fixed by #1541
Closed
Tracked by #1263

Hand-wrap the Table class in Python #1486

jmao-denver opened this issue Oct 26, 2021 · 0 comments · Fixed by #1541
Assignees
@jmao-denver
Labels
feature request New feature or request python-server-side
Milestone
Nov 2021

Comments

@jmao-denver
Copy link
Contributor

Works to be done:

  1. wrap all the Table ops, properties
  2. wrap Table metadata
  3. create unit tests
  4. Docstrings for everything public
@jmao-denver jmao-denver added this to the Oct 2021 milestone Oct 26, 2021
@jmao-denver jmao-denver self-assigned this Oct 26, 2021
@jmao-denver jmao-denver modified the milestones: Oct 2021, Nov 2021 Nov 2, 2021
jmao-denver added a commit to jmao-denver/deephaven-core that referenced this issue Nov 9, 2021
@jmao-denver
Implemented the Table class wraper, fixes deephaven#1486
efc02ca
jmao-denver added a commit to jmao-denver/deephaven-core that referenced this issue Nov 9, 2021
@jmao-denver
Implemented the Table class wrapper, fixes deephaven#1486
89a7ecb
@jmao-denver jmao-denver mentioned this issue Nov 9, 2021
Closed
7 tasks
@jmao-denver jmao-denver linked a pull request Nov 9, 2021 that will close this issue
Implemented the Table class wrapper, fixes #1486 #1541
Merged
jmao-denver added a commit that referenced this issue Nov 23, 2021
@jmao-denver
Implemented the Table class wrapper, fixes #1486 (#1541)
fec97ad 
* Implemented the Table class wrapper, fixes #1486

* Renamed the Java class proxies to be private

This is to avoid potential naming conflicts in the future

* Fixed some issues pointed in PR review

* Resovled the issued raised by the PR reviewers

Got the new agg interface from Ryan and coded against them, however
Ryan's changes haven't landed yet so CI checks are expected to fail

* Changed static agg methods to module level ones

This change is based on feedbacks from devrel. Also to avoid name
shadowing, renamed sum, max, min, count to sum_, max_, min_, count_

* Skipped 3 tests temporarily to make CI happy

* Added return type hints for agg methods

and restored dh-defaults.prop and changed the aj test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmao-denver jmao-denver

Labels
feature request New feature or request python-server-side
Projects
None yet
Milestone
Nov 2021
Development

Successfully merging a pull request may close this issue.

Implemented the Table class wrapper, fixes #1486 jmao-denver/deephaven-core
1 participant
@jmao-denver