Implemented the Table class wrapper, fixes #1486 #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmao-denver
commented
Nov 9, 2021
•
jmao-denver
commented
- Wrapped the Table class and those of its methods that are most usable by Python
- Added agg.py, constants.py
- Added test_table.py, test_table.csv to the test suite
- Added Python docstrings for all public methods/properties in the new code
- Reorganized the source to make it more pep8 compliant
- Fixed a bug in test environment configuration to enable ops on time_tables
- Minor changes to the Python client API to keep it consistent with the server package
jmao-denver
changed the title
jmao-denver
force-pushed
the
feature-1486
branch
from
efc02ca to
89a7ecb
Compare
This was
linked to
issues
Nov 9, 2021
This is to avoid potential naming conflicts in the future
devinrsmith
previously requested changes
Nov 10, 2021
chipkent
requested changes
Nov 12, 2021
Got the new agg interface from Ryan and coded against them, however Ryan's changes haven't landed yet so CI checks are expected to fail
chipkent
requested changes
Nov 17, 2021
chipkent
requested changes
Nov 17, 2021
This change is based on feedbacks from devrel. Also to avoid name shadowing, renamed sum, max, min, count to sum_, max_, min_, count_
chipkent
requested changes
Nov 23, 2021
and restored dh-defaults.prop and changed the aj test cases
chipkent
approved these changes
Nov 23, 2021
jmao-denver
dismissed
devinrsmith’s stale review
addressed all concerns, the reviewer is OK with merging it to unblock dependent PRs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.