Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long column names should be truncated to a maximum width by default (but still resizeable) #1276

Closed
jnumainville opened this issue May 8, 2023 · 0 comments · Fixed by #1574 or deephaven/deephaven-core#4712
Closed

Long column names should be truncated to a maximum width by default (but still resizeable) #1276

jnumainville opened this issue May 8, 2023 · 0 comments · Fixed by #1574 or deephaven/deephaven-core#4712
Assignees
@ethanalvizo
Labels
bug Something isn't working

Comments

@jnumainville
Copy link
Contributor

jnumainville commented May 8, 2023 •
edited by mofojed
Loading

Description
Related to #1283

When creating a column with a very long name, the column name is cut off on the right of the table panel if it is the last column in the table.

Steps to reproduce
Run the following code:

from deephaven import new_table
from deephaven.column import string_col, int_col

result = new_table([
    int_col("I1", [1, 2, 3]),
    int_col("I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I2I23", [4, 5, 6]),
])

Expected results

  1. The column has a maximum width by default (600px?) and column header is truncated by default

Actual results

  1. The column name is cut off (Note the absent 3 in the screenshot below)

Additional details and attachments

Screenshot 2023-05-08 at 3 01 58 PM

Versions

Engine Version: 0.24.0
Web UI Version: 0.34.0
Java Version: 11.0.17
Barrage Version: 0.5.0
@jnumainville jnumainville added bug Something isn't working triage Issue requires triage labels May 8, 2023
This was referenced May 10, 2023
Closed
Open
@vbabich vbabich modified the milestones: Backlog, May 2023 May 10, 2023
@vbabich vbabich removed the triage Issue requires triage label May 10, 2023
@mofojed mofojed changed the title Long column names not handled gracefully Long column names should be truncated to a maximum width by default (but still resizeable) May 10, 2023
@mofojed mofojed modified the milestones: May 2023, June 2023 Jun 19, 2023
@mofojed mofojed modified the milestones: June 2023, July 2023 Aug 4, 2023
@mofojed mofojed modified the milestones: July 2023, August 2023 Aug 28, 2023
@mofojed mofojed modified the milestones: August 2023, September 2023, October 2023 Sep 11, 2023
@ethanalvizo ethanalvizo self-assigned this Oct 13, 2023
@ethanalvizo ethanalvizo mentioned this issue Oct 13, 2023
Merged
ethanalvizo added a commit that referenced this issue Oct 18, 2023
@ethanalvizo
fix: cap width of columns with long names (#1574)
876a6ac 
Closes #1276 
- adds a max column width in GridMetricCalculator
- value is obtained from GridTheme
@mofojed mofojed mentioned this issue Oct 24, 2023
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Oct 25, 2023
@github-actions @deephaven-internal
Update web version 0.51.0 (#4712)
8e63c05 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.51.0

# [0.51.0](deephaven/web-client-ui@v0.50.0...v0.51.0) (2023-10-24)


### Bug Fixes

* Adjusted Monaco "white" colors ([#1594](deephaven/web-client-ui#1594)) ([c736708](deephaven/web-client-ui@c736708)), closes [#1592](deephaven/web-client-ui#1592)
* cap width of columns with long names ([#1574](deephaven/web-client-ui#1574)) ([876a6ac](deephaven/web-client-ui@876a6ac)), closes [#1276](deephaven/web-client-ui#1276)
* Enabled pointer capabilities for Firefox in Playwright ([#1589](deephaven/web-client-ui#1589)) ([f440a38](deephaven/web-client-ui@f440a38)), closes [#1588](deephaven/web-client-ui#1588)
* Remove @deephaven/app-utils from @deephaven/dashboard-core-plugins dependency list ([#1596](deephaven/web-client-ui#1596)) ([7b59763](deephaven/web-client-ui@7b59763)), closes [#1593](deephaven/web-client-ui#1593)
* Tab in console input triggers autocomplete instead of indent ([#1591](deephaven/web-client-ui#1591)) ([fbe1e70](deephaven/web-client-ui@fbe1e70))


### Features

* Theming - Spectrum Provider ([#1582](deephaven/web-client-ui#1582)) ([a4013c0](deephaven/web-client-ui@a4013c0)), closes [#1543](deephaven/web-client-ui#1543)
* Theming Iris Grid ([#1568](deephaven/web-client-ui#1568)) ([ed8f4b7](deephaven/web-client-ui@ed8f4b7))
* web-client-ui changes required for deephaven.ui ([#1567](deephaven/web-client-ui#1567)) ([94ab25c](deephaven/web-client-ui@94ab25c))
* Widget plugins ([#1564](deephaven/web-client-ui#1564)) ([94cc82c](deephaven/web-client-ui@94cc82c)), closes [#1455](deephaven/web-client-ui#1455) [#1167](deephaven/web-client-ui#1167)


### BREAKING CHANGES

- `usePlugins` and `PluginsContext` were moved from
`@deephaven/app-utils` to `@deephaven/plugin`.
- `useLoadTablePlugin` was moved from `@deephaven/app-utils` to
`@deephaven/dashboard-core-plugins`.
- `useConnection` and `ConnectionContext` were moved from
`@deephaven/app-utils` to `@deephaven/jsapi-components`.
- `DeephavenPluginModuleMap` was removed from `@deephaven/redux`. Use
`PluginModuleMap` from `@deephaven/plugin` instead.
* Enterprise will need ThemeProvider for the css
variables to be available





Co-authored-by: deephaven-internal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanalvizo ethanalvizo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@vbabich @mofojed @jnumainville @ethanalvizo