Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"pepr build --withPullSecret" maps into module manifest but not Helm Chart #1660

Closed
2 tasks
btlghrants opened this issue Jan 14, 2025 · 0 comments · Fixed by #1670
Closed
2 tasks

"pepr build --withPullSecret" maps into module manifest but not Helm Chart #1660

btlghrants opened this issue Jan 14, 2025 · 0 comments · Fixed by #1670
Assignees
@cmwylie19
Milestone
v0.43.0

Comments

@btlghrants
Copy link
Contributor

btlghrants commented Jan 14, 2025 •
edited by cmwylie19
Loading

Background

While working #1654 I discovered that the --imagePullSecret flag manipulates settings within the generated pepr module manifests but does not appear to change the Helm templated files... Is that correct?

DOD:

  • Generates imagePullSecret in values.yaml, if exists, templates secret into Deployment templates
  • Documents the values.yaml

Should this be investigated? Current behavior codified in (upcoming) integration test for the pepr build cli:

  • /integration/cli/build.noembed.test.ts : build > builds a module > using non-conflicting build override options > --withPullSecret, works

Definition of Done

  1. figure out whether this is a "real" error or just a matter of test setup / config, and
  2. fix the error (if it is one).
@btlghrants btlghrants converted this from a draft issue Jan 14, 2025
@cmwylie19 cmwylie19 added this to the v0.43.0 milestone Jan 15, 2025
@cmwylie19 cmwylie19 moved this from Questions to 📋 Backlog in Pepr Project Board Jan 15, 2025
@cmwylie19 cmwylie19 self-assigned this Jan 15, 2025
@cmwylie19 cmwylie19 moved this from 📋 Backlog to 🏗 In progress in Pepr Project Board Jan 15, 2025
This was referenced Jan 15, 2025
Open
Merged
@cmwylie19 cmwylie19 moved this from 🏗 In progress to 👀 In review in Pepr Project Board Jan 16, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Pepr Project Board Jan 16, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 16, 2025
@cmwylie19 @btlghrants
chore: pass imagePullSecret to helm (#1670)
d500850 
## Description

Pass build arg `withPullSecret` to helm 

## Related Issue

Fixes #1660 
<!-- or -->
Relates to #1640 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

---------

Signed-off-by: Case Wylie <[email protected]>
Co-authored-by: Barrett LaFrance <[email protected]>
tamirazrab pushed a commit to tamirazrab/pepr that referenced this issue Jan 17, 2025
@cmwylie19 @btlghrants @tamirazrab
chore: pass imagePullSecret to helm (defenseunicorns#1670)
cc528e2 
## Description

Pass build arg `withPullSecret` to helm 

## Related Issue

Fixes defenseunicorns#1660 
<!-- or -->
Relates to defenseunicorns#1640 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

---------

Signed-off-by: Case Wylie <[email protected]>
Co-authored-by: Barrett LaFrance <[email protected]>
@btlghrants btlghrants mentioned this issue Jan 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwylie19 cmwylie19

Labels
None yet
Projects
Pepr Project Board
Archived in project
Milestone
v0.43.0
Development

Successfully merging a pull request may close this issue.

chore: pass imagePullSecret to helm defenseunicorns/pepr
2 participants
@cmwylie19 @btlghrants