Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure helm templates manifests correspond to Kubernetes manifests 1:1 #1640

Closed
cmwylie19 opened this issue Jan 8, 2025 · 1 comment · Fixed by #1688
Closed

Ensure helm templates manifests correspond to Kubernetes manifests 1:1 #1640

cmwylie19 opened this issue Jan 8, 2025 · 1 comment · Fixed by #1688
Assignees
@btlghrants
Labels
tech-debt
Milestone
v0.45.0

Comments

@cmwylie19
Copy link
Contributor

Describe what should be investigated or refactored

We need a way to ensure that our Kubernetes and Helm templated manifests stay in synchronization.

The task is to:

  • generate a Pepr Module with all possible values in the pepr section of package.json
  • Do a helm template . in the dist/static-test-chart > something
  • Compare each manifest to make sure they correspond 1 to 1
@cmwylie19 cmwylie19 added this to the v0.43.0 milestone Jan 8, 2025
@btlghrants btlghrants moved this from 🆕 New to 🏗 In progress in Pepr Project Board Jan 8, 2025
@btlghrants btlghrants self-assigned this Jan 8, 2025
@soltysh
Copy link
Contributor

soltysh commented Jan 9, 2025

One potential solution to this is generating a check sum (eg. SHA512) of the helm template result, and store that in one of the k8s resources as an annotation. This should speed up the comparison.

This was referenced Jan 9, 2025
Merged
Closed
@btlghrants btlghrants linked a pull request Jan 14, 2025 that will close this issue
chore: add return types to build.ts #1651
Closed
5 tasks
@btlghrants btlghrants removed a link to a pull request Jan 14, 2025
chore: add return types to build.ts #1651
Closed
5 tasks
@samayer12 samayer12 mentioned this issue Jan 15, 2025
Merged
5 tasks
btlghrants pushed a commit that referenced this issue Jan 15, 2025
@samayer12
chore: consolidate file parsing implementation (#1663)
92ec7c3 
## Description

This PR provides a fix to feedback on #1642 


## Related Issue

Relates to #1640 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed
@cmwylie19 cmwylie19 mentioned this issue Jan 15, 2025
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 16, 2025
@cmwylie19 @btlghrants
chore: pass imagePullSecret to helm (#1670)
d500850 
## Description

Pass build arg `withPullSecret` to helm 

## Related Issue

Fixes #1660 
<!-- or -->
Relates to #1640 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

---------

Signed-off-by: Case Wylie <[email protected]>
Co-authored-by: Barrett LaFrance <[email protected]>
tamirazrab pushed a commit to tamirazrab/pepr that referenced this issue Jan 17, 2025
@cmwylie19 @btlghrants @tamirazrab
chore: pass imagePullSecret to helm (defenseunicorns#1670)
cc528e2 
## Description

Pass build arg `withPullSecret` to helm 

## Related Issue

Fixes defenseunicorns#1660 
<!-- or -->
Relates to defenseunicorns#1640 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

---------

Signed-off-by: Case Wylie <[email protected]>
Co-authored-by: Barrett LaFrance <[email protected]>
@btlghrants btlghrants mentioned this issue Jan 17, 2025
Merged
5 tasks
@cmwylie19 cmwylie19 modified the milestones: v0.43.0, v0.44.0 Jan 22, 2025
@btlghrants btlghrants moved this from 🏗 In progress to 👀 In review in Pepr Project Board Jan 23, 2025
@cmwylie19 cmwylie19 modified the milestones: v0.44.0, v0.45.0 Jan 24, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 27, 2025
@btlghrants @samayer12
test: demonstrate that 'pepr build' outputs comparable config-derived…
c7e0e57 
… values (#1688)

## Description

Automatically validtes that pepr-native output resource manifest and
helm charted manifest contain comparable config-derived values.

## Related Issue

Fixes #1640 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

---------

Co-authored-by: Sam Mayer <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Pepr Project Board Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btlghrants btlghrants

Labels
tech-debt
Projects
Pepr Project Board
Status: ✅ Done
Milestone
v0.45.0
Development

Successfully merging a pull request may close this issue.

test: demonstrate that 'pepr build' outputs comparable config-derived values defenseunicorns/pepr
3 participants
@soltysh @cmwylie19 @btlghrants