Resolve deprecated [email protected] dependency #1665
Comments
samayer12
added
dependencies
samayer12
changed the title
|
Here's the output of |
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 30, 2025
## Description By overriding glob, we were able to remove inflight, both were deprecated. This seems to still work as expected passing all tests. _Before_ ```plaintext [email protected] /Users/cmwylie19/pepr ├─┬ [email protected] │ └─┬ [email protected] │ └─┬ [email protected] │ └─┬ [email protected] │ └── [email protected] deduped ├─┬ [email protected] │ └─┬ @jest/[email protected] │ ├─┬ @jest/[email protected] │ │ └── [email protected] │ ├─┬ [email protected] │ │ └── [email protected] deduped │ └─┬ [email protected] │ └── [email protected] deduped ├─┬ [email protected] invalid: "3.3.8" from the root project │ └─┬ @kubernetes/[email protected] │ └─┬ [email protected] │ └─┬ [email protected] │ └─┬ [email protected] │ └── [email protected] ├─┬ [email protected] │ └─┬ @sigstore/[email protected] │ └─┬ [email protected] │ └─┬ [email protected] │ └── [email protected] └─┬ [email protected] └─┬ @jest/[email protected] └─┬ [email protected] └─┬ [email protected] └── [email protected] deduped ``` After ```plaintext > npm dedup removed 20 packages, changed 4 packages, and audited 810 packages in 5s 113 packages are looking for funding run `npm fund` for details found 0 vulnerabilities ┌─[cmwylie19@C2WY6FCQVX] - [~/not-pepr/pepr] - [2025-01-30 01:52:06] └─[0] <git:(test_glob_override afe2d26) > npm ls glob [email protected] /Users/cmwylie19/not-pepr/pepr ├─┬ [email protected] │ └─┬ [email protected] │ └─┬ [email protected] │ └─┬ [email protected] │ └── [email protected] deduped ├─┬ [email protected] │ └─┬ @jest/[email protected] │ ├─┬ @jest/[email protected] │ │ └── [email protected] overridden │ ├─┬ [email protected] │ │ └── [email protected] deduped │ └─┬ [email protected] │ └── [email protected] deduped ├─┬ [email protected] │ └─┬ @kubernetes/[email protected] │ └─┬ [email protected] │ └─┬ [email protected] │ └─┬ [email protected] │ └── [email protected] deduped ├─┬ [email protected] │ └─┬ @sigstore/[email protected] │ └─┬ [email protected] │ └─┬ [email protected] │ └── [email protected] deduped └─┬ [email protected] └─┬ @jest/[email protected] └─┬ [email protected] └─┬ [email protected] └── [email protected] deduped > npm ls inflight [email protected] /Users/cmwylie19/not-pepr/pepr └── (empty) ``` ## Related Issue Fixes #1665 Fixes #1668 <!-- or --> Relates to # ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [ ] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed Signed-off-by: Case Wylie <[email protected]> Co-authored-by: Sam Mayer <[email protected]>
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Pepr Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe what should be investigated or refactored
This dependency is deprecated and should be replaced.
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supportedLinks to any relevant code
Additional context
In support of #1125
The text was updated successfully, but these errors were encountered: