Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: demonstrate that 'pepr build' outputs comparable config-derived values #1688

Merged
merged 14 commits into from
Jan 27, 2025

Conversation

btlghrants
Copy link
Contributor

@btlghrants btlghrants commented Jan 17, 2025

Description

Automatically validtes that pepr-native output resource manifest and helm charted manifest contain comparable config-derived values.

Related Issue

Fixes #1640

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@btlghrants btlghrants self-assigned this Jan 17, 2025
@btlghrants btlghrants added this to the v0.43.0 milestone Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.71%. Comparing base (664b912) to head (31b0edd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1688   +/-   ##
=======================================
  Coverage   79.71%   79.71%           
=======================================
  Files          50       50           
  Lines        2115     2115           
  Branches      429      429           
=======================================
  Hits         1686     1686           
  Misses        427      427           
  Partials        2        2           

@cmwylie19 cmwylie19 modified the milestones: v0.43.0, v0.44.0 Jan 22, 2025
@btlghrants btlghrants marked this pull request as ready for review January 23, 2025 16:46
@btlghrants btlghrants requested a review from a team as a code owner January 23, 2025 16:46
@cmwylie19 cmwylie19 modified the milestones: v0.44.0, v0.45.0 Jan 24, 2025
Copy link
Contributor

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are good, implementation details around the tests are for a different conversation once the team norms around testing practices.

@samayer12 samayer12 enabled auto-merge January 27, 2025 15:33
@samayer12 samayer12 added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit c7e0e57 Jan 27, 2025
48 checks passed
@samayer12 samayer12 deleted the 1640_helm_templates_correspond_p2 branch January 27, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Ensure helm templates manifests correspond to Kubernetes manifests 1:1
3 participants