Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

feat(charts): add optional persistence storage to influxdb and grafana #699

Merged
merged 1 commit into from
Jan 24, 2017

Conversation

rimusz
Copy link
Contributor

@rimusz rimusz commented Jan 13, 2017

No description provided.

@deis-bot
Copy link

@lachie83, @bacongobbler and @vdice are potential reviewers of this pull request based on my analysis of git blame information. Thanks @rimusz!

@vdice vdice requested review from vdice and removed request for vdice January 19, 2017 20:58
@vdice
Copy link
Member

vdice commented Jan 19, 2017

@rimusz can you expand on the setup needed to run this? I attempted to test locally using a GKE-based k8s cluster (in combination with the monitor chart changes in deis/monitor#169):

$ helm upgrade smelly-badger workflow-pr/workflow --version v2.7.1-20170119174902-sha.287dd60 -f workflow/values.yaml
Error: UPGRADE FAILED: unable to decode "": [pos 181]: json: error decoding base64 binary '<base64-encoded JSON data>': illegal base64 data at input byte 0

(where I use the workflow chart artifact that uses the monitor PR chart as its sub-chart and I reference the local workflow/values.yaml to get the change in this PR)

As it seems I need to supply the key_json, I do so:

$ B64_KEY_JSON="$(cat /Users/vaughndice/.secrets/deis-sandbox-creds.json | base64 -w 0)"

$ helm upgrade smelly-badger workflow-pr/workflow --version v2.7.1-20170119174902-sha.287dd60 -f workflow/values.yaml --set gcs.key_json="${B64_KEY_JSON}",registry-token-refresher.gcr.key_json="${B64_KEY_JSON}"

...but then pods are stuck in CrashLoopBackOff. I suppose my missing ingredient is specifically enabling use of GCP PD for my cluster?

@rimusz
Copy link
Contributor Author

rimusz commented Jan 20, 2017

ok, been testing myself on GKE and AWS (coreos) on k8s v1.4.x and v1.5.x and it looks like the StorageClass needs to be created before hand.
Not sure how to deal with that yet, as StorageClass is different for GCE/AWS, to make it part of Workflow charts, have in an example in docs?

@vdice
Copy link
Member

vdice commented Jan 20, 2017

@rimusz yes, I think a docs addition to this PR would be suitable in this case -- then, I can use those to guide testing.

@rimusz
Copy link
Contributor Author

rimusz commented Jan 20, 2017

checked with @technosophos there is no way to check that some StorageClass exists or not yet.
which does not make an easy way to install StorageClass for now.
Ok, then I'm going to write a doc on persistence storage for influxdb/grafana and have there two examples of StorageClass for GCE and AWS.

@vdice vdice added this to the v2.11 milestone Jan 23, 2017
@vdice vdice added the LGTM1 label Jan 24, 2017
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested to success in combination with #713 and deis/monitor#169. (PV/PVCs successfully created; grafana dashboards and influxdb metrics persist through pod destruction, as expected.)

@vdice vdice merged commit 6307677 into master Jan 24, 2017
@vdice vdice deleted the add-persistence-grafana-influxdb branch January 24, 2017 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants