allowed paths

CHANGELOG.md

@@ -1,5 +1,6 @@
 # Changelog
 ## Unreleased
+* Added a **validate** step checking for misplaced files (i.e. directly under `Integrations`, or under mistyped folder name)
 * Fixed an issue where **validate** falsely failed with error `DS108` on descriptions ending with brackets that contains a dot at the end of them.
 * Fixed an issue where **modeling-rule test** command failed to properly render the comparison table when boolean value were printed.
 * Fixed an issue were format added a dot at end of the description that already ends with question mark and exclamation mark.

TestSuite/pack.py

@@ -4,10 +4,15 @@
 from demisto_sdk.commands.common.constants import (
     CORRELATION_RULES_DIR,
     DEFAULT_IMAGE_BASE64,
+    INDICATOR_TYPE_PREFIX,
+    LAYOUT_CONTAINER_PREFIX,
+    LAYOUT_PREFIX,
     LAYOUT_RULES_DIR,
     MODELING_RULES_DIR,
     PARSING_RULES_DIR,
+    REPORT_PREFIX,
     TRIGGER_DIR,
+    WIDGET_PREFIX,
     XDRC_TEMPLATE_DIR,
     XSIAM_DASHBOARDS_DIR,
     XSIAM_REPORTS_DIR,
@@ -87,6 +92,7 @@ def __init__(self, packs_dir: Path, name: str, repo):
         self.wizards: List[Wizard] = list()
         self.xdrc_templates: List[XDRCTemplate] = list()
         self.layout_rules: List[LayoutRule] = list()
+        self.connections: List[JSONBased] = list()
 
         # Create base pack
         self._pack_path = packs_dir / self.name
@@ -156,6 +162,9 @@ def __init__(self, packs_dir: Path, name: str, repo):
         self._lists_path = self._pack_path / "Lists"
         self._lists_path.mkdir()
 
+        self._connections_path = self._pack_path / "Connections"
+        self._connections_path.mkdir()
+
         self._parsing_rules_path = self._pack_path / PARSING_RULES_DIR
         self._parsing_rules_path.mkdir()
 
@@ -380,8 +389,9 @@ def create_indicator_field(self, name, content: dict = None) -> JSONBased:
         self.indicator_fields.append(indicator_field)
         return indicator_field
 
-    def create_indicator_type(self, name, content: dict = None) -> JSONBased:
-        prefix = "reputation"
+    def create_indicator_type(
+        self, name, content: dict = None, prefix=INDICATOR_TYPE_PREFIX
+    ) -> JSONBased:
         indicator_type = self._create_json_based(
             name, prefix, content, dir_path=self._indicator_types
         )
@@ -442,34 +452,42 @@ def create_job(
         self.jobs.append(job)
         return job
 
-    def create_layout(self, name, content: dict = None) -> JSONBased:
-        prefix = "layout"
+    def create_layout(
+        self,
+        name,
+        content: dict = None,
+        prefix: str = LAYOUT_PREFIX,
+    ) -> JSONBased:
         layout = self._create_json_based(
             name, prefix, content, dir_path=self._layout_path
         )
         self.layouts.append(layout)
         return layout
 
-    def create_layoutcontainer(self, name, content: Optional[dict] = None) -> JSONBased:
-        if not content:
-            content = {"group": "default"}
-        prefix = "layoutscontainer"
+    def create_layoutcontainer(
+        self, name, content: dict = None, prefix: str = LAYOUT_CONTAINER_PREFIX
+    ) -> JSONBased:
         layoutcontainer = self._create_json_based(
             name, prefix, content, dir_path=self._layout_path
         )
         self.layoutcontainers.append(layoutcontainer)
         return layoutcontainer
 
-    def create_report(self, name, content: dict = None) -> JSONBased:
-        prefix = "report"
+    def create_report(
+        self, name, content: dict = None, prefix=REPORT_PREFIX
+    ) -> JSONBased:
         report = self._create_json_based(
             name, prefix, content, dir_path=self._report_path
         )
         self.reports.append(report)
         return report
 
-    def create_widget(self, name, content: dict = None) -> JSONBased:
-        prefix = "widget"
+    def create_widget(
+        self,
+        name,
+        content: dict = None,
+        prefix: str = WIDGET_PREFIX,
+    ) -> JSONBased:
         widget = self._create_json_based(
             name, prefix, content, dir_path=self._widget_path
         )
@@ -505,14 +523,20 @@ def create_wizard(
         self.wizards.append(wizard)
         return wizard
 
-    def create_list(self, name, content: dict = None) -> JSONBased:
-        prefix = "list"
+    def create_list(self, name, content: dict = None, prefix="list") -> JSONBased:
         list_item = self._create_json_based(
             name, prefix, content, dir_path=self._lists_path
         )
         self.lists.append(list_item)
         return list_item
 
+    def create_connection(self, name: str, content: dict = None) -> JSONBased:
+        connection = self._create_json_based(
+            name, "", content, dir_path=self._connections_path
+        )
+        self.connections.append(connection)
+        return connection
+
     def create_playbook(
         self,
         name: Optional[str] = None,

demisto_sdk/commands/common/constants.py

@@ -30,9 +30,10 @@
 CLASSIFIERS_DIR = "Classifiers"
 MAPPERS_DIR = "Classifiers"
 CONNECTIONS_DIR = "Connections"
+RELEASE_NOTES_DIR = "ReleaseNotes"
+
 PACKS_DIR = "Packs"
 TOOLS_DIR = "Tools"
-RELEASE_NOTES_DIR = "ReleaseNotes"
 TESTS_DIR = "Tests"
 DOC_FILES_DIR = "doc_files"
 DOCUMENTATION_DIR = "Documentation"
@@ -50,6 +51,38 @@
 XDRC_TEMPLATE_DIR = "XDRCTemplates"
 LAYOUT_RULES_DIR = "LayoutRules"
 
+FIRST_LEVEL_FOLDERS_ALLOWED_TO_CONTAIN_FILES = {
+    PLAYBOOKS_DIR,
+    TEST_PLAYBOOKS_DIR,
+    REPORTS_DIR,
+    DASHBOARDS_DIR,
+    INCIDENT_FIELDS_DIR,
+    INCIDENT_TYPES_DIR,
+    INDICATOR_FIELDS_DIR,
+    INDICATOR_TYPES_DIR,
+    GENERIC_TYPES_DIR,
+    GENERIC_MODULES_DIR,
+    GENERIC_DEFINITIONS_DIR,
+    LAYOUTS_DIR,
+    CLASSIFIERS_DIR,
+    MAPPERS_DIR,
+    CONNECTIONS_DIR,
+    RELEASE_NOTES_DIR,
+    DOC_FILES_DIR,
+    JOBS_DIR,
+    PRE_PROCESS_RULES_DIR,
+    LISTS_DIR,
+    PARSING_RULES_DIR,
+    MODELING_RULES_DIR,
+    CORRELATION_RULES_DIR,
+    XSIAM_DASHBOARDS_DIR,
+    XSIAM_REPORTS_DIR,
+    TRIGGER_DIR,
+    WIDGETS_DIR,
+    WIZARDS_DIR,
+    LAYOUT_RULES_DIR,
+}
+
 # NAMES OF ENTITIES
 
 SCRIPT = "script"
@@ -807,6 +840,11 @@ class FileType(str, Enum):
 MODELING_RULE_NAME_SUFFIX = "Modeling Rule"
 XDRC_TEMPLATE_PREFIX = "xdrctemplate"
 LAYOUT_RULE_PREFIX = "layoutrule"
+LAYOUT_CONTAINER_PREFIX = "layoutscontainer"
+INDICATOR_TYPE_PREFIX = "reputation"
+REPORT_PREFIX = "report"
+LAYOUT_PREFIX = "layout"
+WIDGET_PREFIX = "widget"
 
 # Pack Unique Files
 PACKS_WHITELIST_FILE_NAME = ".secrets-ignore"
@@ -819,6 +857,9 @@ class FileType(str, Enum):
 PACKS_FOLDER = "Packs"
 
 CONF_JSON_FILE_NAME = "conf.json"
+GIT_IGNORE_FILE_NAME = ".gitignore"
+PIPFILE_FILE_NAME = "Pipfile"
+PIPFILE_LOCK_FILE_NAME = "Pipfile.lock"
 
 PYTHON_TEST_REGEXES = [PACKS_SCRIPT_TEST_PY_REGEX, PACKS_INTEGRATION_TEST_PY_REGEX]
 
@@ -1867,6 +1908,30 @@ class ParameterType(Enum):
 
 NATIVE_IMAGE_DOCKER_NAME = "demisto/py3-native"
 
+PACK_ROOT_FILE_NAMES = {
+    GIT_IGNORE_FILE_NAME,
+    PACKS_PACK_IGNORE_FILE_NAME,
+    PACKS_WHITELIST_FILE_NAME,
+    AUTHOR_IMAGE_FILE_NAME,
+    PACKS_CONTRIBUTORS_FILE_NAME,
+    PIPFILE_FILE_NAME,
+    PIPFILE_LOCK_FILE_NAME,
+    PACKS_README_FILE_NAME,
+    PACKS_PACK_META_FILE_NAME,
+}
+
+PACK_ROOT_FILE_NAMES = {
+    GIT_IGNORE_FILE_NAME,
+    PACKS_PACK_IGNORE_FILE_NAME,
+    PACKS_WHITELIST_FILE_NAME,
+    AUTHOR_IMAGE_FILE_NAME,
+    PACKS_CONTRIBUTORS_FILE_NAME,
+    PIPFILE_FILE_NAME,
+    PIPFILE_LOCK_FILE_NAME,
+    PACKS_README_FILE_NAME,
+    PACKS_PACK_META_FILE_NAME,
+}
+
 FORMATTING_SCRIPT = "indicator-format"
 
 ENV_SDK_WORKING_OFFLINE = "DEMISTO_SDK_OFFLINE_ENV"