-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allowed paths #2479
allowed paths #2479
Conversation
Pull Request Test Coverage Report for Build 48c9f0b8-295c-4da2-ad61-05cd180aed4a
💛 - Coveralls |
6bf5d45
to
035c954
Compare
…ds-allowed-paths
…ds-allowed-paths
…ds-allowed-paths
@@ -48,6 +49,75 @@ | |||
XDRC_TEMPLATE_DIR = "XDRCTemplates" | |||
LAYOUT_RULES_DIR = "LayoutRules" | |||
|
|||
FIRST_LEVEL_FOLDERS = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when we add new items we will need to add them to this list, which is hard to remember.
we have demisto_sdk.commands.content_graph.common.ContentType.folders()
which doesn't need maintenance - consider using it.
@CodiumAI-Agent /describe |
Preparing pr description... |
@@ -29,6 +30,88 @@ | |||
|
|||
FOUND_FILES_AND_ERRORS: list = [] | |||
FOUND_FILES_AND_IGNORED_ERRORS: list = [] | |||
# allowed errors to be ignored in any supported pack (XSOAR/Partner/Community) only if they appear in the .pack-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why it shows up here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Continued on #4084 |
Added a validate step checking for misplaced files (i.e. directly under
Integrations
, or under mistyped folder name)fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-4563
fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-4891