Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowed paths #2479

Closed
wants to merge 63 commits into from
Closed

allowed paths #2479

wants to merge 63 commits into from

Conversation

dorschw
Copy link
Contributor

@dorschw dorschw commented Nov 16, 2022

Added a validate step checking for misplaced files (i.e. directly under Integrations, or under mistyped folder name)

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-4563
fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-4891

@coveralls
Copy link
Collaborator

coveralls commented Nov 16, 2022

Pull Request Test Coverage Report for Build 48c9f0b8-295c-4da2-ad61-05cd180aed4a

  • 69 of 71 (97.18%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 81.32%

Changes Missing Coverage Covered Lines Changed/Added Lines %
demisto_sdk/commands/validate/validate_manager.py 42 44 95.45%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/validate/validate_manager.py 1 78.3%
Totals Coverage Status
Change from base Build f31d6a1f-f99a-46ea-87e1-5271b192eccc: 0.03%
Covered Lines: 32218
Relevant Lines: 39619

💛 - Coveralls

@@ -48,6 +49,75 @@
XDRC_TEMPLATE_DIR = "XDRCTemplates"
LAYOUT_RULES_DIR = "LayoutRules"

FIRST_LEVEL_FOLDERS = {
Copy link
Contributor

@dantavori dantavori Jul 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we add new items we will need to add them to this list, which is hard to remember.
we have demisto_sdk.commands.content_graph.common.ContentType.folders() which doesn't need maintenance - consider using it.

@dorschw
Copy link
Contributor Author

dorschw commented Jul 23, 2023

@CodiumAI-Agent /describe

@CodiumAI-Agent
Copy link

Preparing pr description...

@@ -29,6 +30,88 @@

FOUND_FILES_AND_ERRORS: list = []
FOUND_FILES_AND_IGNORED_ERRORS: list = []
# allowed errors to be ignored in any supported pack (XSOAR/Partner/Community) only if they appear in the .pack-ignore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why it shows up here

Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@dorschw
Copy link
Contributor Author

dorschw commented Feb 25, 2024

Continued on #4084

@dorschw dorschw closed this Feb 25, 2024
@dorschw dorschw deleted the ds-allowed-paths branch February 25, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants