Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed a bug in validate lists files #3997

Merged
merged 5 commits into from
Feb 6, 2024
Merged

fixed a bug in validate lists files #3997

merged 5 commits into from
Feb 6, 2024

Conversation

merit-maita
Copy link
Contributor

@merit-maita merit-maita commented Jan 30, 2024 •
edited by dorschw
Loading

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-32391

Description

Fixed a bug in validate command with _data.json file types in list directory. (Follow up to #3971)

@merit-maita merit-maita requested a review from dorschw January 30, 2024 10:54
@coveralls
Copy link
Collaborator

coveralls commented Jan 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build ab1ea4ac-3982-4648-9bea-155fbd0cc658

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 80.891%
Files with Coverage Reduction New Missed Lines %
demisto_sdk/commands/content_graph/objects/content_item.py 2 81.48%
Totals Coverage Status
Change from base Build 67a73263-10f5-40b3-9d01-d9e04c40207d: 0.0%
Covered Lines: 36443
Relevant Lines: 45052
💛 - Coveralls

@merit-maita merit-maita self-assigned this Jan 30, 2024
dorschw
dorschw approved these changes Feb 6, 2024
View reviewed changes
.changelog/3997.yml Outdated Show resolved Hide resolved
@merit-maita merit-maita merged commit 6353b6b into master Feb 6, 2024
33 checks passed
@merit-maita merit-maita deleted the validate_list_bug branch February 6, 2024 14:08
This was referenced Feb 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorschw dorschw dorschw approved these changes

Assignees

@merit-maita merit-maita

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merit-maita @coveralls @dorschw