Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a bug in validate lists files #3997

Merged
merged 5 commits into from
Feb 6, 2024
Merged

fixed a bug in validate lists files #3997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e58546
skipped _data.json files in list directory
merit-maita Jan 30, 2024
43b4147
added log
merit-maita Jan 30, 2024
6e80ff7
fix
merit-maita Jan 30, 2024
ef874b5
Update .changelog/3997.yml
merit-maita Feb 6, 2024
223a25e
Merge branch 'master' into validate_list_bug
merit-maita Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changelog/3997.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
changes:
- description: Fixed an issue where **validate** failed on _data.json, when saved in a folder under `Lists` (rather than directly under `Lists`).
type: fix
pr_number: 3997
2 changes: 1 addition & 1 deletion demisto_sdk/commands/validate/old_validate_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,7 @@ def is_skipped_file(self, file_path: str) -> bool:
path.name == "CommonServerPython.py"
and path.parent.parent.name != "Base"
)
or (path.parent.name == LISTS_DIR and path.name.endswith("_data.json"))
or (LISTS_DIR in path.parts[-3:] and path.name.endswith("_data.json"))
)

# flake8: noqa: C901
Expand Down
Loading