-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate content paths #4084
Validate content paths #4084
Conversation
Changelog(s) in markdown:
|
Pull Request Test Coverage Report for Build 8314187683Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
2210bc5
to
0e931f7
Compare
@yuvalbenshalom @YuvHayun @GuyAfik Doc review completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
see my comments.
|
||
|
||
class PathIsFolder(ExemptedPath): | ||
message = "Path is to a folder, these are not validated." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when the validated path is of a folder, rather than a file. Shouldn't happen really.
Co-authored-by: ShirleyDenkberg <[email protected]>
…ds-validate-paths
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-4563
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-4891
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9971 (
BA103
)fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9987 (
IM107
)fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9988 (
IM110
)fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9989 (
LO102
)fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9990 (
LO103
)Description
Validate content is in permitted paths.