-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template sentence in readme validations refactor #4373
Template sentence in readme validations refactor #4373
Conversation
Changelog(s) in markdown:
|
demisto_sdk/commands/validate/validators/RM_validators/RM107_is_template_sentence_in_readme.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/RM_validators/RM107_is_template_sentence_in_readme.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Minor comments.
), | ||
], | ||
False, | ||
2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why all this spaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
automatically
demisto_sdk/commands/validate/validators/RM_validators/RM107_is_template_sentence_in_readme.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/RM_validators/RM107_is_template_sentence_in_readme.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Yuval Hayun <[email protected]>
…s_template_sentence_in_readme.py Co-authored-by: Yuval Hayun <[email protected]>
…s_template_sentence_in_readme.py Co-authored-by: Yuval Hayun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job!
demisto_sdk/commands/validate/validators/RM_validators/RM107_is_template_sentence_in_readme.py
Outdated
Show resolved
Hide resolved
…s_template_sentence_in_readme.py Co-authored-by: Dan Tavori <[email protected]>
Description
Moved RM107 to new validate