Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template sentence in readme validations refactor #4373

Merged
merged 12 commits into from
Jun 24, 2024
Merged

Template sentence in readme validations refactor #4373

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0b4444d
add RM107_is_template_sentence_in_readme
ilaredo Jun 19, 2024
b4daa54
add IsTemplateNotInReadmeValidator and related tests
ilaredo Jun 20, 2024
9dd4b23
add changelog
ilaredo Jun 20, 2024
3bd9c5f
fix pr comment
ilaredo Jun 23, 2024
b93b3f9
Update .changelog/4373.yml
ilaredo Jun 23, 2024
59d866d
Update demisto_sdk/commands/validate/validators/RM_validators/RM107_i…
ilaredo Jun 23, 2024
c870b33
Update demisto_sdk/commands/validate/validators/RM_validators/RM107_i…
ilaredo Jun 23, 2024
828914a
Update demisto_sdk/commands/validate/validators/RM_validators/RM107_i…
ilaredo Jun 24, 2024
ac33a64
merged from master
ilaredo Jun 24, 2024
f3d9840
add "RM107" to sdk_validation_config.toml
ilaredo Jun 24, 2024
8449451
pre commit changes
ilaredo Jun 24, 2024
347c848
fix unit test
ilaredo Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changelog/4373.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
changes:
- description: Added RM107 to the new validation format. The validation checks if given readme is consist %%FILL HERE%% substring or not.
ilaredo marked this conversation as resolved.
Show resolved Hide resolved
type: internal
pr_number: 4373
4 changes: 2 additions & 2 deletions demisto_sdk/commands/validate/sdk_validation_config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ select = [
"DO100", "DO101", "DO102", "DO103", "DO104", "DO105", "DO106",
"DS100", "DS101", "DS105", "DS106", "DS107",
"SC100", "SC105", "SC106", "SC109",
"RM101", "RN103", "RM104", "RM105", "RM106", "RM109", "RM113", "RM114",
"RM101", "RN103", "RM104", "RM105", "RM106", "RM107", "RM109", "RM113", "RM114",
"CL100",
"GF100", "GF101", "GF102",
"IF100", "IF101", "IF102", "IF103", "IF104", "IF105", "IF106", "IF116",
Expand All @@ -61,7 +61,7 @@ select = [
"PA121", "PA123", "PA125", "PA127", "PA130", "PA131", "PA132",
"DO100", "DO101", "DO102", "DO103", "DO104",
"SC100", "SC105", "SC106", "SC109",
"RM104", "RM105", "RM113", "RM114",
"RM104", "RM105", "RM107", "RM113", "RM114",
"CL100",
"GF100", "GF101",
"IF100", "IF101", "IF102", "IF103", "IF104", "IF105", "IF106", "IF116",
Expand Down
Loading
Loading