Pip: Do not raise PathDependenciesNotReachable for missing setup.py #5392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
force-pushed
the
jurre/pip-does-not-require-setup-py
branch
from
4c04a86 to
5e99b8a
Compare
Previously, Dependabot would assume that for every requirements.txt with
a self-reference ('`-e .`), we should expect a `setup.py` to be present. The
self-reference is considered a path dependency that needs a setup.py.
However, nowadays it's valid to have a requirements.txt without a
setup.py. This change accounts for that by still attempting to pull in a
setup.py if it exists, but to not raise and error when it doesn't.
jurre
force-pushed
the
jurre/pip-does-not-require-setup-py
branch
from
5e99b8a to
e0b33c6
Compare
rouge8
reviewed
Jul 19, 2022
This is unrelated to other changes in this PR, but blinker released a new version today, and this breaks one of our tests. We should replace it with a reference to something we own, or lock the constraints so that we don't run into this, but this get's us green for now at least.
DanielNoord
reviewed
Jul 19, 2022
There was a problem hiding this comment.
As far as I can see this should work. Thanks for all the work you did here @jurre 😄
jakecoffman
approved these changes
Jul 19, 2022
pavera
approved these changes
Jul 19, 2022
|
@jurre Do repositories automatically update to a new version of dependabot as soon as it is released? If so, not all problems seem to have been resolved 😅 I still get failing runs on https://github.com/DanielNoord/pydocstringformatter. proxy | 2022/07/20 15:59:55 [024] 404 https://api.github.com:443/repos/DanielNoord/pydocstringformatter/contents/setup.py?ref=fa41767f4a14fbd80464d084e6dcb62a00df44a3
updater | ERROR <job_422750561> Error during file fetching; aborting
updater | INFO <job_422750561> Finished job processing
updater | INFO Results:
updater | Dependabot encountered '1' error(s) during execution, please check the logs for more details.
updater | time="2022-07-20T15:59:56Z" level=info msg="task complete" container_id=job-422750561-file-fetcher exit_code=0 job_id=422750561 step=fetcher
updater | time="2022-07-20T15:59:56Z" level=warning msg="failed during fetch, skipping updater" job_id=422750561Edit: Never mind I misread the git history on |
Yeah I'll try to get a release out in the next few days, but I'm currently traveling, so might be a little slower than normally |
Merged
|
Thanks @jurre this is now working as expected 😄 |
lukpueh
added a commit
to lukpueh/tuf
that referenced
this pull request
Aug 30, 2022
setup.py was removed in favor of setup.cfg in theupdateframework#1626 and re-added later in theupdateframework#1832 to work around a Dependabot issue theupdateframework#1828. This issue seems to have been fixed upstream in dependabot/dependabot-core#5392. Fixes theupdateframework#2089 Signed-off-by: Lukas Puehringer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Dependabot would assume that for every requirements.txt with
a self-reference (
-e .), we should expect asetup.pyto be present. Theself-reference is considered a path dependency that needs a setup.py.
However, nowadays it's valid to have a requirements.txt without a
setup.py. This change accounts for that by still attempting to pull in a
setup.py if it exists, but to not raise and error when it doesn't.
Closes #5324
Resolves #4483