Re-add setup.py to fix dependabot #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 8, 2022 09:12
The Python build tools are fine without a setup.py but Dependabot chokes: dependabot/dependabot-core#4483 Add a setup.py to keep Dependabot happy. Fixes theupdateframework#1828 Signed-off-by: Jussi Kukkonen <[email protected]>
pylint config lives in pyproject.toml nowadays. Signed-off-by: Jussi Kukkonen <[email protected]>
Pull Request Test Coverage Report for Build 1811124958
💛 - Coveralls |
lukpueh
reviewed
Feb 8, 2022
| # This file exists to keep dependabot happy: | ||
| # https://github.com/dependabot/dependabot-core/issues/4483 | ||
| from setuptools import setup | ||
| setup() |
There was a problem hiding this comment.
Out of curiosity, does setup() read from setup.cfg?
There was a problem hiding this comment.
It should, to my knowledge... but I want to still confirm this
There was a problem hiding this comment.
as far as I can tell this works fine: the wheels dist-info contains the correct METADATA.
(as a sidenote, we may be missing a license variable as metadata contains License: UNKNOWN, will file an issue)
lukpueh
approved these changes
Feb 8, 2022
lukpueh
added a commit
to lukpueh/tuf
that referenced
this pull request
Aug 30, 2022
setup.py was removed in favor of setup.cfg in theupdateframework#1626 and re-added later in theupdateframework#1832 to work around a Dependabot issue theupdateframework#1828. This issue seems to have been fixed upstream in dependabot/dependabot-core#5392. Fixes theupdateframework#2089 Signed-off-by: Lukas Puehringer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix the issue with dependabot (#1828) in my fork... There's also a unrelated trivial packaging fix included.
Also, reading the dependabot log I noticed there is one more dependency update I did not include in my latest dependency update PR (pycparser): I'll leave that unfixed for now, we can use it as confirmation that dependabot actually works.