chore(release): 4.3.4 #3218
Merged
chore(release): 4.3.4 #3218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3136) * tests: ensure after and reporter methods can run in isolated context * Update test/integration/full/isolated-env/isolated-env.js Co-authored-by: Wilco Fiers <[email protected]> * cleanup Co-authored-by: Wilco Fiers <[email protected]>
* Fix nativeSelectValue not picking up selection * Use props instead * Add test for selected prop
* add visible checks and tests * fix typo * enable screenreader on isVisible * add tests * revert playground * add aria-hidden tests * add test and clean up * fix test to pass if aria-invalid is false on hidden element
As per the spec, the context parameter can be passed one of the following: > A `NodeList` such as returned by `document.querySelectorAll`. Source: https://www.deque.com/axe/core-documentation/api-documentation/#context-parameter
* fix(is-visible): do not error if window.Node does not exist * circle * Update test/test-virtual-rules.js Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Wilco Fiers <[email protected]>
… messageKey (#3181) * tests: check that every check has a message for every return type and messageKey * finalize * fixes * typo
…nding size (#3186) * fix(color-contrast): account for elements that do not fill entire bounding size * not private
* feat: create issue impact documentation * Update doc/issue_impact.md Co-authored-by: Wilco Fiers <[email protected]> * Update issue_impact.md * Update doc/issue_impact.md Co-authored-by: Stephen Mathieson <[email protected]> Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Stephen Mathieson <[email protected]>
…istbox (#3195) * fix(aria-allowed-children,aria-allowed-parent): allow group role in listbox * fix tests
* fix(color-contrast): properly blend multiple alpha colors * revert shadow * add back shadow color flatten * fix * fix ie11 * type * typo
* fix: Separate Level AAA rules from A and best-practices * Don't log use of wcag21aaa as a tag * address comments
* Update rule-proposal.md * Update doc/rule-proposal.md Co-authored-by: Stephen Mathieson <[email protected]> Co-authored-by: Stephen Mathieson <[email protected]>
* fixes * finalize * sort * test * fix tests * Update lib/commons/color/get-background-stack.js Co-authored-by: Wilco Fiers <[email protected]> * fixes * fix(color-contrast): correctly apply page background color Co-authored-by: Wilco Fiers <[email protected]>
* fix: greater consistency of help / description text * Apply suggestions from code review Co-authored-by: Steven Lambert <[email protected]> * Update lib/rules/p-as-heading.json Co-authored-by: Glenda Sims <[email protected]> Co-authored-by: Steven Lambert <[email protected]> Co-authored-by: Glenda Sims <[email protected]>
* fix(color-contrast): correctly handle nested scroll regions * revert changes from previous pr
…z-index (#3209) * fix(color-contrast): correctly work with positioned elements without z-index * correct link * add back test * fix * revert playground * typo * typo * Update lib/commons/dom/get-rect-stack.js Co-authored-by: Wilco Fiers <[email protected]> * Update test/commons/dom/get-element-stack.js Co-authored-by: Wilco Fiers <[email protected]> * fix Co-authored-by: Wilco Fiers <[email protected]>
…ildren (#3203) * fixes * finalize * sort * test * fix tests * Update lib/commons/color/get-background-stack.js Co-authored-by: Wilco Fiers <[email protected]> * fixes * split out pr * order * rounding Co-authored-by: Wilco Fiers <[email protected]>
|
|
straker
force-pushed
the
release-4.3.4
branch
from
5f25497 to
9430193
Compare
straker
force-pushed
the
release-4.3.4
branch
from
9430193 to
8ea779b
Compare
WilcoFiers
previously approved these changes
Oct 19, 2021
There was a problem hiding this comment.
Release Audit
- fix(nativeSelectValue): update selected value on change #3154
- chore(p-as-heading): add
margindescription back tocheck-options.md#3180 Should have been docs, not chore. Minor issue - fix(aria-prohibited-attr): update metadata message #3206
Note: We added the "tests: fix for release" commit to the release outside a PR in order to fix failing tests on this release. The tests fail because some of the changes were not picked into this release.
straker
force-pushed
the
release-4.3.4
branch
from
8ea779b to
e1cd670
Compare
|
One more commit: |
WilcoFiers
approved these changes
Oct 25, 2021
This was referenced Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking some
fixeshad code from a fewfeatprs, so had to manually edit the files to remove the new changes and tests.