Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Akmal / feat: update entry spot description" #13865

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Revert "Akmal / feat: update entry spot description" #13865

merged 1 commit into from
Feb 28, 2024

Conversation

maryia-deriv
Copy link
Contributor

Reverts #13854

review-deriv
review-deriv reviewed Feb 28, 2024
View reviewed changes
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@boring-cyborg boring-cyborg bot added the Trader label Feb 28, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app 🔄 Building (Inspect) Visit Preview Feb 28, 2024 8:11am

@maryia-deriv maryia-deriv merged commit c63115e into master Feb 28, 2024
2 of 6 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

balakrishna-deriv added a commit that referenced this pull request Apr 1, 2024
@balakrishna-deriv
Revert "Revert "Akmal / feat: update entry spot description (#13854)" (…
2815c0f 
…#13865)"

This reverts commit c63115e.
@balakrishna-deriv balakrishna-deriv mentioned this pull request Apr 1, 2024
Merged
balakrishna-deriv added a commit that referenced this pull request Apr 1, 2024
@balakrishna-deriv
Revert "Revert "Akmal / feat: update entry spot description (#13854)" (…
e7c12ed 
…#13865)" (#14415)

This reverts commit c63115e.
@shahzaib-deriv shahzaib-deriv mentioned this pull request May 7, 2024
Merged
@ali-hosseini-deriv ali-hosseini-deriv deleted the revert-13854-f-update-entry-spot-description branch August 16, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@review-deriv review-deriv review-deriv left review comments

@kate-deriv kate-deriv kate-deriv approved these changes

@akmal-deriv akmal-deriv akmal-deriv approved these changes

@matin-deriv matin-deriv Awaiting requested review from matin-deriv

Assignees
No one assigned
Labels
Trader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maryia-deriv @akmal-deriv @kate-deriv @review-deriv