Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Akmal / feat: update entry spot description"" #14415

Conversation

balakrishna-deriv
Copy link
Contributor

Reverts #13865

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

Copy link

vercel bot commented Apr 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Apr 1, 2024 9:11am

Copy link

sonarqubecloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Apr 1, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14415](https://github.com/binary-com/deriv-app/pull/14415)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-revert-13865-revert-13854-f-update-entry-s-9af721.binary.sx?qa_server=red.derivws.com&app_id=24162
    - **Original**: https://deriv-app-git-revert-13865-revert-13854-f-update-entry-s-9af721.binary.sx
- **App ID**: `24162`

Copy link
Contributor

github-actions bot commented Apr 1, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-revert-13865-revert-13854-f-update-entry-s-9af721.binary.sx/

@balakrishna-deriv balakrishna-deriv merged commit e7c12ed into master Apr 1, 2024
8 checks passed
@coveralls
Copy link

Coverage Status

coverage: 39.515% (-0.001%) from 39.516%
when pulling 2815c0f on revert-13865-revert-13854-f-update-entry-spot-description
into 9c25063 on master.

@ali-hosseini-deriv ali-hosseini-deriv deleted the revert-13865-revert-13854-f-update-entry-spot-description branch August 16, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants