Akmal | Henry / feat: dtrader guides improvements #17806
+1,200
−302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [BOT-2440]/mayuran/tutorial-video bug (#17669) * fix: tutorial fix * fix: bug * [FEQ] george / FEQ-2702 / Improve Coverall workflow time execution. Part 2. Adding caching npm packages (#17702) * chore: add caching * fix: 🚑 cache not reading form base repo * Revert "[FEQ] george / FEQ-2702 / Improve Coverall workflow time execution. P…" (#17706) This reverts commit 89a90c7. * translations: 📚 sync translations with crowdin (#17707) Co-authored-by: DerivFE <[email protected]> * [FEQ] george / FEQ-2702 / Improve Coverall workflow time execution. Part 2. Adding caching npm packages (#17708) * chore: add caching * fix: 🚑 cache not reading form base repo * fix: 🚑 add update cache workflow, fix coverall restore cache * Rename update_cache.yml to update_npm_cache.yml * fix: add push trigger to master for coverall workflow (#17713) * [TRAH4525] Suisin/chore: fix cfd not showing to spain users (#17709) * chore: fix cfd not showing to spain users * fix: loader blinking issue * chore: revert types changes for stores * perf: remove redundant cache key restoration (#17718) * chore: remove utm_data and gclid from cookie upon logout (#17720) * Nuzhy/CSIT-1700/intercom integration (#17672) * chore: added POC for intercom * chore: keep user anonymous for now * chore: added livechat condition for intercom * chore: added user signature * fix: clear chat on loggout handled * fix: nitpick * fix: fetch flag in hook, removed from live-chat * fix: re-initialize intercom on logout --------- Co-authored-by: Prince <[email protected]> * [WALL] Jim/WALL-5129/redirection to os real account sign up flow from mf traders hub on add new wallet section (#17640) * feat: redirect to tradershub out systems * chore: pass currency to query params * test: fix failing tests and add more tests * test: remove unnecessary attributes from mock objects * test: remove unnecessary attributes from mock objects * test: remove unnecessary attributes from mock objects * chore: update feature flag key * [CRO-880]/Agrim_Amina/fix binary userid (#17673) * fix: testing user id * chore: add cacheTrackEvents for missing user id * fix: fix type * fix: revert isReady change * fix: failing test cases * fix: empty commit * fix: test * fix: userid * fix: Trigger Build --------- Co-authored-by: Agrim Jain <[email protected]> * Akmal / feat: replace dtrader videos (#17564) * feat: replace dtrader videos * feat: remove extra variable * fix: stake value fix on crypto currency change (#17683) * DTRA-2131 / Kate / Virtual keyboard hook (#17559) * refactor: add hook for detecting keyboard * chore: replace logs * chore: add one more check * refactor: add scrolling for rm * refactor: add tests * refactor: apply suggestions * translations: 📚 sync translations with crowdin (#17729) Co-authored-by: DerivFE <[email protected]> * translations: 📚 sync translations with crowdin (#17731) Co-authored-by: DerivFE <[email protected]> * [P2PS] / Ameerul / P2PS-4532 PA client gets logout when login (#17699) * fix: added is_authroize check from client store before calling p2p_settings * fix: set mt5_login_list in WS.authorized * translations: 📚 sync translations with crowdin (#17736) Co-authored-by: DerivFE <[email protected]> * fix(wallets): 🚑 remaining amount error (#17680) * DON't MERGE - [WALL] george / WALL-5147 / Gold MT5 account creation flow on Wallets (#17607) * feat(wallets): ✨ add Gold MT5 account creation real and demo * chore: replace company name from API for tnc, add dml shortcode support * chore: add gold mt5 acc into compare acc table * feat(wallets): ✨ add mt5 gold into compare accounts table real + demo * feat(wallets): ✨ add mf mt5 gold support * feat(wallets): ✨ implement compare accounts table for MFW clients * fix(wallets): 🔥 remove Boom 300 from compare acc table * [WALL] Jim/WALL-5218/send all accounts with their tokens to os (#17738) * chore: send all accounts with their tokens * chore: change os_auth_token to os_auth_tokens * ci: fix failing tests * ci: fix failing tests * [TRAH]/Hasan/TRAH-4439/Gold MT5 account creation flow (#17565) * feat: added gold account details to the mt5 account list * feat: added gold icon * feat: added new tag to gold card * feat: added gold success icon * feat: added multi action to gold * feat: added gold icon in trade modal * feat: added gold to transfer page * feat: added gold title to trade modal * feat: optimized svg accounts * fix: bring back cfd_account_display function call * feat: added mauritius tnc * feat: added gold title to success message * feat: added gold demo title to enter password title * feat: added gold compare accounts * feat: added gold demo compare accounts * fix: build issue * fix: build issue * fix: removed console * fix: fixed financial demo title * fix: fixed financial title * fix: changed description * feat: added mt5 gold icon in close account modal * fix: added shortcode in cfd constant * fix: added shortcode in cfd constant * fix: fixed investor password for gold account * feat: fixed short code generation * fix: made dml capital * fix: made dml capital * fix: removed gold from compare account * fix: reset password for MF account * fix: eu trade modal icon * translations: 📚 sync translations with crowdin (#17755) Co-authored-by: DerivFE <[email protected]> * [TRAH4562] Suisin/chore: add condition to check is_eu_user on giving contentFlag (#17742) * chore: add condition to check is_eu_user on giving contentFlag * chore: fix mt5 icon not displaying when logged out * [WALL5207] Suisin/chore: update content for tnc modal (#17733) * chore: update content for tnc modal * chore: add livechat link * [BOT]/mayuran/bot-2180/ improve journal messages (#17666) * fix: improve journal messages * fix: change unwanted code * fix: unwanted code * fix: improve journal messages * fix: move helper function * fix: error message * fix: added translation * fix: Search by "all" results are not shown correctly (#17725) --------- Co-authored-by: mayuran-deriv <[email protected]> Co-authored-by: George Usynin <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <[email protected]> Co-authored-by: Sui Sin <[email protected]> Co-authored-by: Shayan Khaleghparast <[email protected]> Co-authored-by: Nuzhy-Deriv <[email protected]> Co-authored-by: Prince <[email protected]> Co-authored-by: Jim Daniels Wasswa <[email protected]> Co-authored-by: amina-deriv <[email protected]> Co-authored-by: Agrim Jain <[email protected]> Co-authored-by: vinu-deriv <[email protected]> Co-authored-by: kate-deriv <[email protected]> Co-authored-by: Ameerul Hady <[email protected]> Co-authored-by: Hasan Mobarak <[email protected]> Co-authored-by: maryia-matskevich-deriv <[email protected]>
* fix: package-lock * fix: init guide component fix * fix: make custom hook for guide states * fix: make state inside hook rerender only when necessary * fix: market selector tour guide * fix: guide for trade param quick adjustment * fix: wrong import * fix: some change
akmal-deriv
requested review from
nijil-deriv,
vinu-deriv,
amina-deriv,
balakrishna-deriv,
farrah-deriv,
habib-deriv,
matin-deriv,
sandeep-deriv,
yashim-deriv and
dan-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* fix: package-lock * fix: init guide component fix * fix: make custom hook for guide states * fix: make state inside hook rerender only when necessary * fix: market selector tour guide * fix: guide for trade param quick adjustment * fix: wrong import * fix: some change * fix: wrong file change * fix: lint * fix: something
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-feature-dtrader-guides-improvements.binary.sx/ |
* fix: package-lock * fix: init guide component fix * fix: make custom hook for guide states * fix: make state inside hook rerender only when necessary * fix: market selector tour guide * fix: guide for trade param quick adjustment * fix: wrong import * fix: some change * fix: wrong file change * fix: lint * fix: something * fix: working market-selector guide * fix: clean up * fix: add joyride on parameter click
* fix: temp commit * fix: do not reset local storage at every step * chore: improve imports order
* fix: package-lock * fix: init guide component fix * fix: make custom hook for guide states * fix: make state inside hook rerender only when necessary * fix: market selector tour guide * fix: guide for trade param quick adjustment * fix: wrong import * fix: some change * fix: wrong file change * fix: lint * fix: something * fix: working market-selector guide * fix: clean up * fix: add joyride on parameter click * fix: test cases * fix: updated test * chore: remove unused code and modify test cases * fix: update tests * fix: failing tests * fix: css
|
kate-deriv
approved these changes
Dec 27, 2024
nijil-deriv
previously approved these changes
Dec 27, 2024
* fix: package-lock * fix: init guide component fix * fix: make custom hook for guide states * fix: make state inside hook rerender only when necessary * fix: market selector tour guide * fix: guide for trade param quick adjustment * fix: wrong import * fix: some change * fix: wrong file change * fix: lint * fix: something * fix: working market-selector guide * fix: clean up * fix: add joyride on parameter click * fix: test cases * fix: updated test * chore: remove unused code and modify test cases * fix: update tests * fix: failing tests * fix: css * fix: change to quill token * fix: lint * fix: broken duration fix * fix: reposition tooltip * fix: quick adj guide * fix: bottom nav disappearing
|
2 similar comments
|
|
kate-deriv
approved these changes
Jan 8, 2025
nijil-deriv
previously approved these changes
Jan 8, 2025
* fix: package-lock * fix: init guide component fix * fix: make custom hook for guide states * fix: make state inside hook rerender only when necessary * fix: market selector tour guide * fix: guide for trade param quick adjustment * fix: wrong import * fix: some change * fix: wrong file change * fix: lint * fix: something * fix: working market-selector guide * fix: clean up * fix: add joyride on parameter click * fix: test cases * fix: updated test * chore: remove unused code and modify test cases * fix: update tests * fix: failing tests * fix: css * fix: change to quill token * fix: lint * fix: broken duration fix * fix: reposition tooltip * fix: quick adj guide * fix: bottom nav disappearing * fix: flickering guide
|
* fix: package-lock * fix: init guide component fix * fix: make custom hook for guide states * fix: make state inside hook rerender only when necessary * fix: market selector tour guide * fix: guide for trade param quick adjustment * fix: wrong import * fix: some change * fix: wrong file change * fix: lint * fix: something * fix: working market-selector guide * fix: clean up * fix: add joyride on parameter click * fix: test cases * fix: updated test * chore: remove unused code and modify test cases * fix: update tests * fix: failing tests * fix: css * fix: change to quill token * fix: lint * fix: broken duration fix * fix: reposition tooltip * fix: quick adj guide * fix: bottom nav disappearing * fix: flickering guide * fix: calculation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This feature introduces improvements to DTrader guides, enhancing usability and user understanding.
These improvements aim to make DTrader guides more helpful and intuitive.