Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on compat_resource #188

Merged
merged 2 commits into from
Feb 12, 2018

Conversation

bablakely
Copy link
Contributor

Remove dependency on compat_resource (deprecated). Fixes #186, but may break older clients

@coveralls
Copy link

coveralls commented Feb 6, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 1fea01d on bablakely:compat_resource into 6332377 on dev-sec:master.

@artem-sidorenko
Copy link
Member

@bablakely thanks for this PR!

I pushed that to travis for testing, https://travis-ci.org/artem-forks/chef-os-hardening/builds/339072994 . I expect some jobs to break because of chef 12.5 version pinning. I'll have a look again in the next days

@artem-sidorenko
Copy link
Member

@bablakely can you please change the CHEF_VERSION=12.5.1 to CHEF_VERSION=12.14.60in .travis.yml?

@bablakely
Copy link
Contributor Author

No problem @artem-sidorenko . Done and tests re-running.

@artem-sidorenko artem-sidorenko merged commit afdec51 into dev-sec:master Feb 12, 2018
@artem-sidorenko
Copy link
Member

@bablakely thank you!

@bablakely
Copy link
Contributor Author

No problem; thanks again for this great resource (and your help with this and the other PRs)!

Veraticus added a commit to symondsandson/chef-os-hardening that referenced this pull request Apr 5, 2018
* 'master' of github.com:dev-sec/chef-os-hardening: (71 commits)
  fix metadata (dev-sec#204)
  improve testing around amazon linux (dev-sec#202)
  Temporary disable failing tests
  Require the kitchen-inspec 0.23.1
  Fix ubuntu /var/log permissions for containers
  Run dokken tests in the Travis CI for forks
  Flexible control of included recipes
  Allow specifying an alternate cookbook name for PAM templates
  Lazy pin the sysctl major version
  add support for amazon linux
  Unpin sysctl dependency
  Remove dependency on compat_resource (dev-sec#188)
  Use the new droplets with more memory
  Fix fedora shadow permissions
  Fedora 25 is EOL, replacing with 27
  Release 3.0.0
  Make fedora tests pass
  Skip auditd tests
  Make ubuntu tests pass
  RH family: adapt some settings, as RH has better defaults
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants