-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve testing around amazon linux #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But let us remove the EOL distros
README.md
Outdated
### Platform | ||
|
||
- Debian 6, 7, 8 | ||
- Ubuntu 12.04, 14.04, 16.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we maybe remove the ubuntu 12.04 and centos 5? They are EOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fedora 24 and debian 6 are EOL too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I update and remove them from metadata, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can update the metadata in the next major version, but I am not mentioning the old system in the readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to remove them from metadata too: I’m not sure if cookbook will work properly on this old distros at all. Its in my eyes only a leftover, which I missed to remove in the PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to do that in another PR if you're okay with that.
53146ce
to
586d3bd
Compare
README.md
Outdated
- RHEL 6, 7 | ||
- CentOS 6, 7 | ||
- Oracle Linux 6, 7 | ||
- Fedora 24, 25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 26 and 27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I move this to the other PR to, so that this PR focus on amazon linux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
586d3bd
to
671cf39
Compare
All the metadata/platform updates moved to #204 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chris-rock thanks!
* 'master' of github.com:dev-sec/chef-os-hardening: (71 commits) fix metadata (dev-sec#204) improve testing around amazon linux (dev-sec#202) Temporary disable failing tests Require the kitchen-inspec 0.23.1 Fix ubuntu /var/log permissions for containers Run dokken tests in the Travis CI for forks Flexible control of included recipes Allow specifying an alternate cookbook name for PAM templates Lazy pin the sysctl major version add support for amazon linux Unpin sysctl dependency Remove dependency on compat_resource (dev-sec#188) Use the new droplets with more memory Fix fedora shadow permissions Fedora 25 is EOL, replacing with 27 Release 3.0.0 Make fedora tests pass Skip auditd tests Make ubuntu tests pass RH family: adapt some settings, as RH has better defaults ...
This builds on top of #194 and adds testing for Amazon Linux 1