Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve testing around amazon linux #202

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Conversation

chris-rock
Copy link
Member

This builds on top of #194 and adds testing for Amazon Linux 1

@coveralls
Copy link

coveralls commented Mar 15, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 671cf39 on chris-rock/amazonlinux into d897534 on master.

Copy link
Member

@artem-sidorenko artem-sidorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But let us remove the EOL distros

README.md Outdated
### Platform

- Debian 6, 7, 8
- Ubuntu 12.04, 14.04, 16.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we maybe remove the ubuntu 12.04 and centos 5? They are EOL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fedora 24 and debian 6 are EOL too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I update and remove them from metadata, too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update the metadata in the next major version, but I am not mentioning the old system in the readme.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to remove them from metadata too: I’m not sure if cookbook will work properly on this old distros at all. Its in my eyes only a leftover, which I missed to remove in the PRs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to do that in another PR if you're okay with that.

@chris-rock chris-rock force-pushed the chris-rock/amazonlinux branch from 53146ce to 586d3bd Compare March 15, 2018 15:43
README.md Outdated
- RHEL 6, 7
- CentOS 6, 7
- Oracle Linux 6, 7
- Fedora 24, 25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 26 and 27

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I move this to the other PR to, so that this PR focus on amazon linux

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@chris-rock chris-rock force-pushed the chris-rock/amazonlinux branch from 586d3bd to 671cf39 Compare March 16, 2018 15:14
@chris-rock
Copy link
Member Author

All the metadata/platform updates moved to #204

Copy link
Member

@artem-sidorenko artem-sidorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris-rock thanks!

@chris-rock chris-rock merged commit 1ed3e9a into master Mar 16, 2018
@chris-rock chris-rock deleted the chris-rock/amazonlinux branch March 16, 2018 18:17
Veraticus added a commit to symondsandson/chef-os-hardening that referenced this pull request Apr 5, 2018
* 'master' of github.com:dev-sec/chef-os-hardening: (71 commits)
  fix metadata (dev-sec#204)
  improve testing around amazon linux (dev-sec#202)
  Temporary disable failing tests
  Require the kitchen-inspec 0.23.1
  Fix ubuntu /var/log permissions for containers
  Run dokken tests in the Travis CI for forks
  Flexible control of included recipes
  Allow specifying an alternate cookbook name for PAM templates
  Lazy pin the sysctl major version
  add support for amazon linux
  Unpin sysctl dependency
  Remove dependency on compat_resource (dev-sec#188)
  Use the new droplets with more memory
  Fix fedora shadow permissions
  Fedora 25 is EOL, replacing with 27
  Release 3.0.0
  Make fedora tests pass
  Skip auditd tests
  Make ubuntu tests pass
  RH family: adapt some settings, as RH has better defaults
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants