Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin sysctl dependency #195

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Unpin sysctl dependency #195

merged 1 commit into from
Feb 13, 2018

Conversation

artem-sidorenko
Copy link
Member

and resolve the cleanup issue of old configs on our side

Fixes #192

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @artem-sidorenko

# https://github.com/dev-sec/chef-os-hardening/issues/166#issuecomment-322433264
# https://github.com/sous-chefs/sysctl/pull/61/files#diff-25e5d4a4446ae12a0d6f1162b6160375
old_sysctl_conf_file = '/etc/sysctl.conf'
if platform_family?('arch', 'debian', 'rhel', 'fedora', 'amazon', 'suse')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for covering this!

and resolve the cleanup issue of old configs on our side

Signed-off-by: Artem Sidorenko <[email protected]>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6864dd3 on sysctl into afdec51 on master.

@artem-sidorenko artem-sidorenko merged commit b62f3e1 into master Feb 13, 2018
@artem-sidorenko artem-sidorenko deleted the sysctl branch February 13, 2018 13:52
@damacus
Copy link

damacus commented Feb 17, 2018

FYI, we're close to releasing a new version of the sysctl cookbook, with just custom resources. It'll be a major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency on pinned, old version of sysctl
5 participants