add basic support for amazon linux #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris-rock thanks for this! I started to check the situation with sysctl, probably I will create today another PR which should solve the sysctl cleanup problem on our side. It would be nice to update this PR and to exclude here any sysctl related changes |
|
@artem-sidorenko Will do the update, once your PR is there. Lets hold this one until you are ready. |
|
@chris-rock here you are #195 |
Signed-off-by: Christoph Hartmann <[email protected]>
chris-rock
force-pushed
the
chris-rock/amzn2-support
branch
from
da45a44 to
25f69fb
Compare
chris-rock
changed the title
|
@artem-sidorenko all rebased on your improvement! |
artem-sidorenko
approved these changes
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Amazon Linux. The biggest change is the switch to the latest sysctl cookbook. This was pinned previously by @artem-sidorenko and discussed #166 (comment)
Are there any side-effects by moving to the latest version @artem-sidorenko ?
We may consider merging #193 first
Chef Omnibus install has an issue with Amazon Linux as described here chef/omnitruck#346