Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non-versioned Features when generating outdated report #731

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Jan 24, 2024

Made a couple changes to the outdated command.

  • Addresses devcontainer outdated gives incorrect current version information for some deprecated features #712 by omitting the deprecated "short-hand" Feature syntax from the output of outdated.
    • This is a bit opinionated, but my reasoning here is that - since there is no way for the user to alter these Feature versions (they're "held back" to the major version from when they were deprecated) - it doesn't make sense to surface in outdated.
    • Omitting these Features from outdated will subsequently cause the dependabot integration to not consider them for version updates, which is already being done as an exceptional case.
  • Updates to getRef() to better filter out non-OCI Features, namely "local Features".
  • Fix a sorting bug that caused --output-format text to exit unsuccessfully if a "local Feature" was present in the config.
    • Added a test to exercise that code path

@joshspicer joshspicer changed the title i Ignore non-OCI Features when generated outdated report Jan 24, 2024
@joshspicer joshspicer changed the title Ignore non-OCI Features when generated outdated report Ignore non-versioned Features when generated outdated report Jan 24, 2024
@joshspicer joshspicer changed the title Ignore non-versioned Features when generated outdated report Ignore non-versioned Features when generating outdated report Jan 24, 2024
@joshspicer joshspicer force-pushed the joshspicer/outdated-cmd-local-features branch from b966ba8 to c8edbed Compare January 24, 2024 23:02
chrmarti
chrmarti previously approved these changes Jan 25, 2024
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshspicer joshspicer dismissed stale reviews from samruddhikhandale and chrmarti via c7207ed January 25, 2024 18:13
@joshspicer joshspicer merged commit f507bb8 into main Jan 25, 2024
37 checks passed
@joshspicer joshspicer deleted the joshspicer/outdated-cmd-local-features branch January 25, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants