-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore non-versioned Features when generating outdated
report
#731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshspicer
changed the title
Ignore non-OCI Features when generated
Ignore non-versioned Features when generated Jan 24, 2024
outdated
reportoutdated
report
joshspicer
changed the title
Ignore non-versioned Features when generated
Ignore non-versioned Features when generating Jan 24, 2024
outdated
reportoutdated
report
joshspicer
force-pushed
the
joshspicer/outdated-cmd-local-features
branch
from
January 24, 2024 23:02
b966ba8
to
c8edbed
Compare
chrmarti
previously approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
samruddhikhandale
previously approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡
joshspicer
dismissed stale reviews from samruddhikhandale and chrmarti
via
January 25, 2024 18:13
c7207ed
samruddhikhandale
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a couple changes to the
outdated
command.devcontainer outdated
gives incorrect current version information for some deprecated features #712 by omitting the deprecated "short-hand" Feature syntax from the output ofoutdated
.outdated
.outdated
will subsequently cause the dependabot integration to not consider them for version updates, which is already being done as an exceptional case.getRef()
to better filter out non-OCI Features, namely "local Features".--output-format text
to exit unsuccessfully if a "local Feature" was present in the config.