Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed templates with dependabot.yml #231

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Jan 24, 2024

Given https://containers.dev/guide/dependabot is now GA, make it as easy as possible for folks to stay up-to-date with Feature updates with Dependabot!

refs: https://github.com/github/codespaces/issues/15875,https://github.com/dependabot/dependabot-core/issues/7000,https://github.com/dependabot/dependabot-core/issues/7000

I recognize it's opinionated to add a .github folder, but given the tight integration with dependabot here (without community alternatives at the moment) I think it's OK. Please feel free to share your thoughts in a discussion (and we're open to considering other additions to these templates if it highly enriches the experience on other platforms!)

@joshspicer joshspicer requested a review from a team as a code owner January 24, 2024 17:48
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding these files automatically is great for now. ✨ However, if the community don't like automatic addition of yml, then we can think about updating the VS Code UX with a new prompt.

Left one comment, besides that LGTM

src/alpine/.github/dependabot.yml Show resolved Hide resolved
@joshspicer
Copy link
Member Author

joshspicer commented Jan 24, 2024

However, if the community don't like automatic addition of yml, then we can think about updating the VS Code UX with a new prompt.

Agreed! I don't think we currently support excluding files through the VS Code prompt flow, so that's a nice feature to consider and then include here!

We do already a mechanism in place to exclude the metadata files, but this runs too early https://github.com/devcontainers/cli/blob/e12c2800fdbca85cf48cdfa6d3499862526c2ddb/src/spec-configuration/containerTemplatesOCI.ts#L49

@joshspicer joshspicer merged commit 61d0683 into main Jan 24, 2024
39 checks passed
@joshspicer joshspicer deleted the joshspicer/seed-dependabot branch January 24, 2024 19:18
joshspicer added a commit to devcontainers/cli that referenced this pull request Jan 25, 2024
joshspicer added a commit to devcontainers/cli that referenced this pull request Jan 25, 2024
* break test

* patch

* exit early if local Feature

* add non-versionable Features to config

* update test given devcontainers/templates#231

* sanity check negative case
eitsupi added a commit to rocker-org/devcontainer-templates that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants