-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seed templates with dependabot.yml
#231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding these files automatically is great for now. ✨ However, if the community don't like automatic addition of yml
, then we can think about updating the VS Code UX with a new prompt.
Left one comment, besides that LGTM
Agreed! I don't think we currently support excluding files through the VS Code prompt flow, so that's a nice feature to consider and then include here! We do already a mechanism in place to exclude the metadata files, but this runs too early https://github.com/devcontainers/cli/blob/e12c2800fdbca85cf48cdfa6d3499862526c2ddb/src/spec-configuration/containerTemplatesOCI.ts#L49 |
* break test * patch * exit early if local Feature * add non-versionable Features to config * update test given devcontainers/templates#231 * sanity check negative case
Given https://containers.dev/guide/dependabot is now GA, make it as easy as possible for folks to stay up-to-date with Feature updates with Dependabot!
refs: https://github.com/github/codespaces/issues/15875,https://github.com/dependabot/dependabot-core/issues/7000,https://github.com/dependabot/dependabot-core/issues/7000
I recognize it's opinionated to add a
.github
folder, but given the tight integration with dependabot here (without community alternatives at the moment) I think it's OK. Please feel free to share your thoughts in a discussion (and we're open to considering other additions to these templates if it highly enriches the experience on other platforms!)