-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alias and remove duplicate files #2001
Conversation
Oh, btw this is the PR where i asked myself if we want to have newlines in the svg files, or if we need to remove them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor modifications need to be made for digitalocean
, postcss
, and gatsby
, but aside from that all is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the postcss-original.svg
has multiple paths with different fill colors. I think this SVG needs to remain, but the paths need to be unified, and the fill color changed to #dd3a0aff
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in #2012
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gatsby-original-wordmark.svg
has 2 paths and 2 different fill colors. It unfortunately cant be used for plain-wordmark
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in #2006
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in #2005
@weh, the newline character at the end of the file is used, if I'm not mistaken, for compatibility reasons. |
First of all, thank you @weh and @canaleal for quickly make pull requests to fix the found errors. That means a lot! 🚀 @weh, as @canaleal had explained in this comment, we need to make some changes in the icons. This type of error needs a pull request for each icon, like the one you made for opensuse, because even if we are not modifying an icon, some icon will be deleted eventually. I'm not sure, but since pull request titles together with |
sure, i will split the request, and also fix the mentioned svg files when i find time 👍 |
Closing this PR since it's being split into multiple PR's |
Double check these details before you open a PR
Features
This solves a part of the open tasks from #1998 (comment)
Notes
I will check on the opensuse icons later. the svg files currently include inkscape metadata. either there is a open PR or i add it later