Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update icon: typo3 (original, original-wordmark, plain-wordmark, line, line-wordmark) #2048

Merged
merged 4 commits into from
Dec 3, 2023
Merged

update icon: typo3 (original, original-wordmark, plain-wordmark, line, line-wordmark) #2048

merged 4 commits into from
Dec 3, 2023

Conversation

weh
Copy link
Contributor

@weh weh commented Nov 23, 2023 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

  • Removed padding and optimized images
  • Replaced duplicate original/plain with alias
  • Added line versions

This PR closes NONE

Part of #1998 and #2001

Notes

@weh weh mentioned this pull request Nov 23, 2023
Closed
9 tasks
@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team November 23, 2023 09:56
@lunatic-fox lunatic-fox mentioned this pull request Nov 24, 2023
Closed
lunatic-fox
lunatic-fox previously approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍🏼
Thank you for this contribution! 🚀
image
image
image
image

Snailedlt
Snailedlt reviewed Nov 25, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plain and line versions are missing the fill attribute, which makes those versions black. That's fine for the font since we can change the color easily, but for the svg versions it's more difficult to change the color.
imo we should use the color from devicon.json as fill for all icons with a single path

@lunatic-fox I know you have some opinions on this, what do you think?

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 25, 2023
@lunatic-fox
Copy link
Contributor

The plain and line versions are missing the fill attribute, which makes those versions black. That's fine for the font since we can change the color easily, but for the svg versions it's more difficult to change the color. imo we should use the color from devicon.json as fill for all icons with a single path

@lunatic-fox I know you have some opinions on this, what do you think?

I got your point @Snailedlt and yeah, all this time I was considering devicon.json color just for font versions, but didn't consider for SVG versions. Making changes on the next commit.

lunatic-fox
lunatic-fox approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
image
image

@lunatic-fox lunatic-fox mentioned this pull request Nov 28, 2023
Merged
1 task
Snailedlt
Snailedlt approved these changes Dec 3, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for another great contribution! 💯 🙇

@Snailedlt Snailedlt merged commit bdf86bb into devicons:develop Dec 3, 2023
4 checks passed
@lunatic-fox lunatic-fox mentioned this pull request Jan 10, 2024
Merged
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@weh @lunatic-fox @Snailedlt
update icon: typo3 (original, original-wordmark, plain-wordmark, line…
706c93a 
…, line-wordmark) (devicons#2048)

* Update typo3 icons

* Remove icons style attribute

* Change fill color from `line`, `line-wordmark` and `plain-wordmark` versions

---------

Co-authored-by: Josélio Júnior <[email protected]>
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@Snailedlt Snailedlt Snailedlt approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@canaleal canaleal Awaiting requested review from canaleal canaleal was automatically assigned from devicons/devicon__reviewers

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weh @lunatic-fox @Snailedlt