Don't cause MSBuild warnings 'expected' failures #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's expected that `git` won't be in %PATH% so in this scenario we should not generate an `MSB3073` warning, nor write stderr as high importance. This removes these lines from every build on windows for me: ``` 1>'git' is not recognized as an internal or external command, 1>operable program or batch file. 1>C:\Users\almcgo\.nuget\packages\gitinfo\2.0.11\build\GitInfo.targets(897,3): warning MSB3073: The command "git --version" exited with code 9009. ```
|
i'm not sure if this is 100% correct actually - let me test a bit more with a clean tree |
|
Nah, it is fine! |
|
@kzu any chance we can get this, or a variant of it, into a release? It'd be good to not emit warnings for expected things. |
kzu
approved these changes
Dec 13, 2019
|
Thanks for that! It's good to be able to knock out these warnings without disabling them :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's expected that
gitwon't be in %PATH% so in this scenario we shouldnot generate an
MSB3073warning, nor write stderr as high importance.This removes these lines from every build on windows for me: