Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cause MSBuild warnings 'expected' failures #90

Merged
merged 1 commit into from
Dec 13, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Don't cause MSBuild warnings 'expected' failures
It's expected that `git` won't be in %PATH% so in this scenario we should
not generate an `MSB3073` warning, nor write stderr as high importance.

This removes these lines from every build on windows for me:
```
1>'git' is not recognized as an internal or external command,
1>operable program or batch file.
1>C:\Users\almcgo\.nuget\packages\gitinfo\2.0.11\build\GitInfo.targets(897,3): warning MSB3073: The command "git --version" exited with code 9009.
```
alanmcgovern authored Feb 1, 2019

Verified

This commit was signed with the committer’s verified signature.
watson Thomas Watson
commit 8e89ecf50a6d478a515b16634b3add1a8df5d645
3 changes: 2 additions & 1 deletion src/GitInfo/build/GitInfo.targets
Original file line number Diff line number Diff line change
@@ -905,7 +905,8 @@
<Exec Command='git --version'
EchoOff='true'
ContinueOnError='true'
StandardErrorImportance='high'
IgnoreExitCode='true'
StandardErrorImportance='low'
StandardOutputImportance='low'>
<Output TaskParameter="ExitCode" PropertyName="MSBuildLastExitCode" />
</Exec>