Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Self-closing HTML tags #544

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix: Self-closing HTML tags #544

merged 2 commits into from
Dec 9, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

Fix a linter error reported by latest Svelte v5 linter in #541:

Self-closing HTML tags for non-void elements are ambiguous — use <div ...></div> rather than <div ... />(element_invalid_self_closing_tag) svelte/valid-compile

Changes

  • Replace self closing tags. e.g. <div /> -> <div></div>

@peterpeterparker peterpeterparker requested review from a team as code owners December 9, 2024 06:16
@peterpeterparker peterpeterparker merged commit de4cd5a into main Dec 9, 2024
8 checks passed
@peterpeterparker peterpeterparker deleted the feat/Self-closing-HTML-tags branch December 9, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @dskloetd