Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Self-closing HTML tags #544

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix: Self-closing HTML tags #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
592f5a7
fix: Self-closing HTML tags
peterpeterparker Dec 9, 2024
03cab1f
Merge branch 'main' into feat/Self-closing-HTML-tags
peterpeterparker Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/components/Backdrop.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
on:keypress={($event) => handleKeyPress({ $event, callback: close })}
class:disablePointerEvents
data-tid="backdrop"
/>
></div>

<style lang="scss">
@use "../styles/mixins/interaction";
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/ProgressBar.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
aria-valuemax={max}
aria-valuenow={totalValue}
style={inlineStyle}
/>
></progress>
<slot name="bottom" />
</div>

Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/ProgressSteps.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

<span class="text">{text}</span>

<div class:line={!last} />
<div class:line={!last}></div>

{#if state === "completed"}
<span class="state">{$i18n.progress.completed}</span>
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/QRCode.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
style={`width: ${size.width > 0 ? `${size.width}px` : "100%"}; height: ${
size.width > 0 ? `${size.width}px` : "100%"
}`}
/>
></canvas>
{/if}

{#if showLogo}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/QRCodeReader.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
const mirror = isDesktop();
</script>

<article class="reader" {id} class:mirror />
<article class="reader" {id} class:mirror></article>

<style lang="scss">
.reader {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/Segment.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
>
{#if nonNullish(indicator)}
<div class="indicator">
<div class="indicator-background" />
<div class="indicator-background"></div>
</div>
{/if}

Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/Toggle.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
aria-label={ariaLabel}
{disabled}
/>
<label for={id} />
<label for={id}></label>
</div>

<style lang="scss">
Expand Down
6 changes: 3 additions & 3 deletions src/tests/lib/components/ContentTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
</script>

<Content>
<div data-tid="content-test-slot" />
<div data-tid="content-test-title-slot" slot="title" />
<div data-tid="content-test-toolbar-end-slot" slot="toolbar-end" />
<div data-tid="content-test-slot"></div>
<div data-tid="content-test-title-slot" slot="title"></div>
<div data-tid="content-test-toolbar-end-slot" slot="toolbar-end"></div>
</Content>
2 changes: 1 addition & 1 deletion src/tests/lib/components/IslandTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
</script>

<Island>
<div data-tid="island-test-slot" />
<div data-tid="island-test-slot"></div>
</Island>
6 changes: 3 additions & 3 deletions src/tests/lib/components/MenuItemTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
</script>

<MenuItem href="https://test">
<div data-tid="menuitem-test-icon" slot="icon" />
<div data-tid="menuitem-test-default" />
<div data-tid="menuitem-test-status-icon" slot="statusIcon" />
<div data-tid="menuitem-test-icon" slot="icon"></div>
<div data-tid="menuitem-test-default"></div>
<div data-tid="menuitem-test-status-icon" slot="statusIcon"></div>
</MenuItem>
2 changes: 1 addition & 1 deletion src/tests/lib/components/MenuTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
</script>

<Menu>
<div data-tid="menu-test-slot" />
<div data-tid="menu-test-slot"></div>
</Menu>
4 changes: 2 additions & 2 deletions src/tests/lib/components/NavTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
</script>

<Nav>
<div data-tid="nav-test-1" />
<div data-tid="nav-test-2" />
<div data-tid="nav-test-1"></div>
<div data-tid="nav-test-2"></div>
</Nav>
2 changes: 1 addition & 1 deletion src/tests/lib/components/PopoverTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
</script>

<Popover visible={true}>
<div data-tid="Popover-slot" />
<div data-tid="Popover-slot"></div>
</Popover>
4 changes: 2 additions & 2 deletions src/tests/lib/components/SplitBlockTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
</script>

<SplitBlock>
<div data-tid="content-test-start-slot" slot="start" />
<div data-tid="content-test-end-slot" slot="end" />
<div data-tid="content-test-start-slot" slot="start"></div>
<div data-tid="content-test-end-slot" slot="end"></div>
</SplitBlock>
8 changes: 4 additions & 4 deletions src/tests/lib/components/SplitContentTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
</script>

<SplitContent bind:this={originalComponent}>
<div data-tid="content-test-start-slot" slot="start" />
<div data-tid="content-test-end-slot" slot="end" />
<div data-tid="content-test-title-slot" slot="title" />
<div data-tid="content-test-toolbar-end-slot" slot="toolbar-end" />
<div data-tid="content-test-start-slot" slot="start"></div>
<div data-tid="content-test-end-slot" slot="end"></div>
<div data-tid="content-test-title-slot" slot="title"></div>
<div data-tid="content-test-toolbar-end-slot" slot="toolbar-end"></div>
</SplitContent>
4 changes: 2 additions & 2 deletions src/tests/lib/components/SplitPaneTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
</script>

<SplitPane>
<div data-tid="split-pane-test-slot" />
<div data-tid="split-pane-test-menu-slot" slot="menu" />
<div data-tid="split-pane-test-slot"></div>
<div data-tid="split-pane-test-menu-slot" slot="menu"></div>
</SplitPane>
4 changes: 2 additions & 2 deletions src/tests/lib/components/StretchPaneTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
</script>

<StretchPane>
<div data-tid="stretch-pane-test-slot" />
<div data-tid="stretch-pane-test-menu-slot" slot="menu" />
<div data-tid="stretch-pane-test-slot"></div>
<div data-tid="stretch-pane-test-menu-slot" slot="menu"></div>
</StretchPane>
2 changes: 1 addition & 1 deletion src/tests/lib/components/TestIdWrapperTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
</script>

<TestIdWrapper {testId}>
<div data-tid={childTestId} />
<div data-tid={childTestId}></div>
</TestIdWrapper>
6 changes: 3 additions & 3 deletions src/tests/lib/components/ToolbarTest.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
</script>

<Toolbar>
<div data-tid="toolbar-test-start-slot" />
<div data-tid="toolbar-test-slot" />
<div data-tid="toolbar-test-end-slot" />
<div data-tid="toolbar-test-start-slot"></div>
<div data-tid="toolbar-test-slot"></div>
<div data-tid="toolbar-test-end-slot"></div>
</Toolbar>
Loading