Show deprecation on arithmetic word operations #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this extracts, off #2309, the refactoring of `value`, without any user-visible changes. This should make reviewing #2309 easier, and also pave the way to deprecating the word type. Because this is based off #2309, it includes some changes to the prims. In particular, the `num_conv_t1_t2` family is now for trapping conversions, and `num_warp_t1_2` is for wrapping (currently: to Word, and between fixed types).
Builds on top of #2324, and is extracted from #2324. Because this should be backwards-compatible, there is still the +>> operator. Once `WordN` is removed, we only want and need the `>>` operator (taking the signedness from the type). Until then, ` * `>>` is unsigned on Nat and Word, and signed on Int. * `+>>` is always signed
Co-authored-by: Andreas Rossberg <[email protected]>
as it is slated for removal with WordN
Co-authored-by: Claudio Russo <[email protected]>
and some knock-on effects for `charToWord32`
Co-authored-by: Claudio Russo <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>
|
This PR does not affect the produced WebAssembly code. |
rossberg
approved these changes
Feb 12, 2021
Comment on lines
+190
to
+193
| | Prim (Word8|Word16|Word32|Word64), AddOp -> word_op_warn "+" | ||
| | Prim (Word8|Word16|Word32|Word64), SubOp -> word_op_warn "-" | ||
| | Prim (Word8|Word16|Word32|Word64), MulOp -> word_op_warn "*" | ||
| | Prim (Word8|Word16|Word32|Word64), PowOp -> word_op_warn "**" |
There was a problem hiding this comment.
You can do this and remove the open Type
Suggested change
| | Prim (Word8|Word16|Word32|Word64), AddOp -> word_op_warn "+" | |
| | Prim (Word8|Word16|Word32|Word64), SubOp -> word_op_warn "-" | |
| | Prim (Word8|Word16|Word32|Word64), MulOp -> word_op_warn "*" | |
| | Prim (Word8|Word16|Word32|Word64), PowOp -> word_op_warn "**" | |
| | Prim T.(Word8|Word16|Word32|Word64), AddOp -> word_op_warn "+" | |
| | Prim T.(Word8|Word16|Word32|Word64), SubOp -> word_op_warn "-" | |
| | Prim T.(Word8|Word16|Word32|Word64), MulOp -> word_op_warn "*" | |
| | Prim T.(Word8|Word16|Word32|Word64), PowOp -> word_op_warn "**" |
There was a problem hiding this comment.
Nope, that would exclue Prim. And then you need extra parenthesis, which I like less than you do ;-)
There was a problem hiding this comment.
Or put T. before those as well -- still a net win. :)
|
Did you see the user’s guide changes or did we race there? |
Co-authored-by: Andreas Rossberg <[email protected]>
|
Ah, no, we raced indeed. LGTM as well. |
Co-authored-by: Claudio Russo <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>
Co-authored-by: Claudio Russo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next step in the plan of
#1824 (comment)
should be merged after #2326
Add a migration guide to the users guide.