Skip to content

Commit

Permalink
Fix local deployments (#3772)
Browse files Browse the repository at this point in the history
# Motivation
With dfx 0.15.1 this fails with a confusing error message:
```
./deploy.sh --nns-dapp local
```
This is due to the network being defined but not exported.

# Changes
- Export `DFX_NETWORK`.

# Tests
* Tested locally. CI tests are underway but I am unlikely to get them
finished this morning so this is to unblock developers.
* Fixes and tests for appropriate error messages are in #3771 

# Todos

- [x] Add entry to changelog (if necessary).
  • Loading branch information
bitdivine authored Nov 16, 2023
1 parent 22f866d commit e9683b6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG-Nns-Dapp-unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,6 @@ proposal is successful, the changes it released will be moved from this file to
#### Fixed

* Remove accidentally committed (empty) directory and fix commit patterns.
* Fix local deployments with `dfx 0.15.1`.

#### Security
1 change: 1 addition & 0 deletions deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ help_text() {
}

#
export DFX_NETWORK
DFX_NETWORK=local # which network to deploy to

# Whether to run each action:
Expand Down

0 comments on commit e9683b6

Please sign in to comment.