Error if network is defined but not exported #3771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitdivine
force-pushed
the
deploy-error-message
branch
from
38c9d97 to
96ca3fc
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
# Motivation With dfx 0.15.1 this fails with a confusing error message: ``` ./deploy.sh --nns-dapp local ``` This is due to the network being defined but not exported. # Changes - Export `DFX_NETWORK`. # Tests * Tested locally. CI tests are underway but I am unlikely to get them finished this morning so this is to unblock developers. * Fixes and tests for appropriate error messages are in #3771 # Todos - [x] Add entry to changelog (if necessary).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
DFX_NETWORKis typically provided to dfx build commands as an exported environment variable. When checking thatDFX_NETWORKis provided, we need to check specifically that it is exported as otherwise it is possible to get very confusing behaviour in which the network is defined in one part of the deployment but not another.Changes
DFX_NETWORKis exported.Tests
DFX_NETWORKnot being exported.Todos