Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-643 Update new project files for JS user library (2nd attempt) #201

Merged
merged 2 commits into from
Nov 22, 2019

Conversation

paulyoung
Copy link
Contributor

Changing the base branch in #190 made a mess of things, so this cherry-picks the only relevant commit from there.

Unverified

The committer email address is not verified.
@paulyoung
Copy link
Contributor Author

Here are some things I shared on Slack that relate to this PR:

Question about the intended behavior with serving front end assets; were any decisions made about how canister JS files should be made available?

I ask because serve_root in dfx.json defaults to src/hello/public, which (I think) means we can’t directly import canisters/hello/main.js (for example), at least not with a relative import which seems the simplest way.

Should we be copying files to the public directory?


I’m realizing that I didn’t run into this in my PR with the example because I had /public instead of /src/hello/public. I don’t remember why; perhaps it was to workaround this or it could be that I thought it made more sense.

I think it may have actually been that I was using a minimal webpack config.

@paulyoung
Copy link
Contributor Author

So, I believe the reason I was able to get around any issues with serve_root and where files were actually located (even in the nix store) was because this example used a minimal webpack config to bundle everything into a single file.

https://github.com/dfinity-lab/sdk/tree/80018dfd0fb2a45c4a35ef1232763281560e79ba/js-user-library/examples/hello

@paulyoung paulyoung marked this pull request as ready for review November 22, 2019 19:17
@paulyoung paulyoung requested a review from a team as a code owner November 22, 2019 19:17
@paulyoung
Copy link
Contributor Author

This doesn't work as-is (yet) for reasons mentioned above but it's closer to that I think we want to do, and is no less broken than what was there before, so on that basis I'll merge this.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@paulyoung paulyoung merged commit 8f1cbb1 into master Nov 22, 2019
@paulyoung paulyoung deleted the paulyoung/dfx-new-project-files branch November 22, 2019 19:21
dfinity-bot added a commit that referenced this pull request Jul 8, 2020
## Changelog for advisory-db:
Branch: 
Commits: [rustsec/advisory-db@aa789b9c...6b10ce09](rustsec/advisory-db@aa789b9...6b10ce0)

* [`cff4f820`](rustsec/advisory-db@cff4f82) warn about CVE-2020-1967
* [`b0bc62bd`](rustsec/advisory-db@b0bc62b) Add `cargo-deny` to the list RustSec clients
* [`e44e26f3`](rustsec/advisory-db@e44e26f) Assign RUSTSEC-2020-0015 to openssl-src
* [`b1d3a5e7`](rustsec/advisory-db@b1d3a5e) Advisory for rio
* [`25f622ba`](rustsec/advisory-db@25f622b) tempdir crate has been deprecated since 2018-02-13.
* [`a3c68605`](rustsec/advisory-db@a3c6860) net2 crate has been deprecated; use socket2 instead
* [`1639be65`](rustsec/advisory-db@1639be6) Assign RUSTSEC-2020-0016 to net2
* [`7d4ce9ae`](rustsec/advisory-db@7d4ce9a) Assign RUSTSEC-2018-0017 to tempdir
* [`0f5a2dc2`](rustsec/advisory-db@0f5a2dc) Add advisory for internment ([RustSec/advisory-db⁠#306](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/306))
* [`8587ec25`](rustsec/advisory-db@8587ec2) Assign RUSTSEC-2020-0017 to internment ([RustSec/advisory-db⁠#309](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/309))
* [`5049594b`](rustsec/advisory-db@5049594) Add unmaintained crate advisory for `block-cipher-trait` (RUSTSEC-2020-0018) ([RustSec/advisory-db⁠#310](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/310))
* [`ae22eb47`](rustsec/advisory-db@ae22eb4) CONTRIBUTING: mention soundness issues ([RustSec/advisory-db⁠#314](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/314))
* [`7c96397e`](rustsec/advisory-db@7c96397) Security advisory for AtheMathmo/rulinalg[RustSec/advisory-db⁠#201](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/201)
* [`8149410e`](rustsec/advisory-db@8149410) Fix toml format error
* [`45495b76`](rustsec/advisory-db@45495b7) .github: bump rustsec-admin cache key ([RustSec/advisory-db⁠#321](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/321))
* [`418954a9`](rustsec/advisory-db@418954a) Create github action to assign RUSTSEC ids ([RustSec/advisory-db⁠#311](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/311))
* [`48c86534`](rustsec/advisory-db@48c8653) Attempt to fix failing assign-ids task ([RustSec/advisory-db⁠#322](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/322))
* [`de07a7d2`](rustsec/advisory-db@de07a7d) Add tokio-rustls DoS advisory ([RustSec/advisory-db⁠#304](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/304))
* [`46c23f6c`](rustsec/advisory-db@46c23f6) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#323](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/323))
* [`9cd619f1`](rustsec/advisory-db@9cd619f) make memoffset advisory informational ([RustSec/advisory-db⁠#317](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/317))
* [`1dfcb1d6`](rustsec/advisory-db@1dfcb1d) .github: lint advisories after assigning ID ([RustSec/advisory-db⁠#324](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/324))
* [`6e2241c0`](rustsec/advisory-db@6e2241c) stb_truetype crate has been deprecated; use ttf-parser instead ([RustSec/advisory-db⁠#307](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/307))
* [`07ae3fb2`](rustsec/advisory-db@07ae3fb) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#325](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/325))
* [`49fcc50d`](rustsec/advisory-db@49fcc50) Reflect PR feedback and describe what might happen
* [`297725a1`](rustsec/advisory-db@297725a) README.md: bump maintained quarter comment
* [`73b40e7d`](rustsec/advisory-db@73b40e7) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#326](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/326))
* [`ee09393d`](rustsec/advisory-db@ee09393) Security advisory for bqv/ozone
* [`c649f538`](rustsec/advisory-db@c649f53) Assign RUSTSEC-2020-0022 to ozone ([RustSec/advisory-db⁠#329](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/329))
* [`6b56bccc`](rustsec/advisory-db@6b56bcc) Assign RUSTSEC IDs
* [`6b10ce09`](rustsec/advisory-db@6b10ce0) Update yaml-rust advirsory to indicate clap as non-vulnerable ([RustSec/advisory-db⁠#331](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/331))
dfinity-bot added a commit that referenced this pull request Jul 9, 2020
## Changelog for advisory-db:
Branch: 
Commits: [rustsec/advisory-db@aa789b9c...6b10ce09](rustsec/advisory-db@aa789b9...6b10ce0)

* [`cff4f820`](rustsec/advisory-db@cff4f82) warn about CVE-2020-1967
* [`b0bc62bd`](rustsec/advisory-db@b0bc62b) Add `cargo-deny` to the list RustSec clients
* [`e44e26f3`](rustsec/advisory-db@e44e26f) Assign RUSTSEC-2020-0015 to openssl-src
* [`b1d3a5e7`](rustsec/advisory-db@b1d3a5e) Advisory for rio
* [`25f622ba`](rustsec/advisory-db@25f622b) tempdir crate has been deprecated since 2018-02-13.
* [`a3c68605`](rustsec/advisory-db@a3c6860) net2 crate has been deprecated; use socket2 instead
* [`1639be65`](rustsec/advisory-db@1639be6) Assign RUSTSEC-2020-0016 to net2
* [`7d4ce9ae`](rustsec/advisory-db@7d4ce9a) Assign RUSTSEC-2018-0017 to tempdir
* [`0f5a2dc2`](rustsec/advisory-db@0f5a2dc) Add advisory for internment ([RustSec/advisory-db⁠#306](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/306))
* [`8587ec25`](rustsec/advisory-db@8587ec2) Assign RUSTSEC-2020-0017 to internment ([RustSec/advisory-db⁠#309](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/309))
* [`5049594b`](rustsec/advisory-db@5049594) Add unmaintained crate advisory for `block-cipher-trait` (RUSTSEC-2020-0018) ([RustSec/advisory-db⁠#310](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/310))
* [`ae22eb47`](rustsec/advisory-db@ae22eb4) CONTRIBUTING: mention soundness issues ([RustSec/advisory-db⁠#314](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/314))
* [`7c96397e`](rustsec/advisory-db@7c96397) Security advisory for AtheMathmo/rulinalg[RustSec/advisory-db⁠#201](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/201)
* [`8149410e`](rustsec/advisory-db@8149410) Fix toml format error
* [`45495b76`](rustsec/advisory-db@45495b7) .github: bump rustsec-admin cache key ([RustSec/advisory-db⁠#321](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/321))
* [`418954a9`](rustsec/advisory-db@418954a) Create github action to assign RUSTSEC ids ([RustSec/advisory-db⁠#311](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/311))
* [`48c86534`](rustsec/advisory-db@48c8653) Attempt to fix failing assign-ids task ([RustSec/advisory-db⁠#322](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/322))
* [`de07a7d2`](rustsec/advisory-db@de07a7d) Add tokio-rustls DoS advisory ([RustSec/advisory-db⁠#304](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/304))
* [`46c23f6c`](rustsec/advisory-db@46c23f6) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#323](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/323))
* [`9cd619f1`](rustsec/advisory-db@9cd619f) make memoffset advisory informational ([RustSec/advisory-db⁠#317](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/317))
* [`1dfcb1d6`](rustsec/advisory-db@1dfcb1d) .github: lint advisories after assigning ID ([RustSec/advisory-db⁠#324](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/324))
* [`6e2241c0`](rustsec/advisory-db@6e2241c) stb_truetype crate has been deprecated; use ttf-parser instead ([RustSec/advisory-db⁠#307](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/307))
* [`07ae3fb2`](rustsec/advisory-db@07ae3fb) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#325](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/325))
* [`49fcc50d`](rustsec/advisory-db@49fcc50) Reflect PR feedback and describe what might happen
* [`297725a1`](rustsec/advisory-db@297725a) README.md: bump maintained quarter comment
* [`73b40e7d`](rustsec/advisory-db@73b40e7) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#326](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/326))
* [`ee09393d`](rustsec/advisory-db@ee09393) Security advisory for bqv/ozone
* [`c649f538`](rustsec/advisory-db@c649f53) Assign RUSTSEC-2020-0022 to ozone ([RustSec/advisory-db⁠#329](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/329))
* [`6b56bccc`](rustsec/advisory-db@6b56bcc) Assign RUSTSEC IDs
* [`6b10ce09`](rustsec/advisory-db@6b10ce0) Update yaml-rust advirsory to indicate clap as non-vulnerable ([RustSec/advisory-db⁠#331](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/331))
mergify bot pushed a commit that referenced this pull request Jul 14, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
## Changelog for advisory-db:
Branch: 
Commits: [rustsec/advisory-db@aa789b9c...6b10ce09](rustsec/advisory-db@aa789b9...6b10ce0)

* [`cff4f820`](rustsec/advisory-db@cff4f82) warn about CVE-2020-1967
* [`b0bc62bd`](rustsec/advisory-db@b0bc62b) Add `cargo-deny` to the list RustSec clients
* [`e44e26f3`](rustsec/advisory-db@e44e26f) Assign RUSTSEC-2020-0015 to openssl-src
* [`b1d3a5e7`](rustsec/advisory-db@b1d3a5e) Advisory for rio
* [`25f622ba`](rustsec/advisory-db@25f622b) tempdir crate has been deprecated since 2018-02-13.
* [`a3c68605`](rustsec/advisory-db@a3c6860) net2 crate has been deprecated; use socket2 instead
* [`1639be65`](rustsec/advisory-db@1639be6) Assign RUSTSEC-2020-0016 to net2
* [`7d4ce9ae`](rustsec/advisory-db@7d4ce9a) Assign RUSTSEC-2018-0017 to tempdir
* [`0f5a2dc2`](rustsec/advisory-db@0f5a2dc) Add advisory for internment ([RustSec/advisory-db⁠#306](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/306))
* [`8587ec25`](rustsec/advisory-db@8587ec2) Assign RUSTSEC-2020-0017 to internment ([RustSec/advisory-db⁠#309](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/309))
* [`5049594b`](rustsec/advisory-db@5049594) Add unmaintained crate advisory for `block-cipher-trait` (RUSTSEC-2020-0018) ([RustSec/advisory-db⁠#310](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/310))
* [`ae22eb47`](rustsec/advisory-db@ae22eb4) CONTRIBUTING: mention soundness issues ([RustSec/advisory-db⁠#314](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/314))
* [`7c96397e`](rustsec/advisory-db@7c96397) Security advisory for AtheMathmo/rulinalg[RustSec/advisory-db⁠#201](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/201)
* [`8149410e`](rustsec/advisory-db@8149410) Fix toml format error
* [`45495b76`](rustsec/advisory-db@45495b7) .github: bump rustsec-admin cache key ([RustSec/advisory-db⁠#321](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/321))
* [`418954a9`](rustsec/advisory-db@418954a) Create github action to assign RUSTSEC ids ([RustSec/advisory-db⁠#311](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/311))
* [`48c86534`](rustsec/advisory-db@48c8653) Attempt to fix failing assign-ids task ([RustSec/advisory-db⁠#322](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/322))
* [`de07a7d2`](rustsec/advisory-db@de07a7d) Add tokio-rustls DoS advisory ([RustSec/advisory-db⁠#304](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/304))
* [`46c23f6c`](rustsec/advisory-db@46c23f6) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#323](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/323))
* [`9cd619f1`](rustsec/advisory-db@9cd619f) make memoffset advisory informational ([RustSec/advisory-db⁠#317](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/317))
* [`1dfcb1d6`](rustsec/advisory-db@1dfcb1d) .github: lint advisories after assigning ID ([RustSec/advisory-db⁠#324](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/324))
* [`6e2241c0`](rustsec/advisory-db@6e2241c) stb_truetype crate has been deprecated; use ttf-parser instead ([RustSec/advisory-db⁠#307](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/307))
* [`07ae3fb2`](rustsec/advisory-db@07ae3fb) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#325](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/325))
* [`49fcc50d`](rustsec/advisory-db@49fcc50) Reflect PR feedback and describe what might happen
* [`297725a1`](rustsec/advisory-db@297725a) README.md: bump maintained quarter comment
* [`73b40e7d`](rustsec/advisory-db@73b40e7) Assign RUSTSEC IDs ([RustSec/advisory-db⁠#326](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/326))
* [`ee09393d`](rustsec/advisory-db@ee09393) Security advisory for bqv/ozone
* [`c649f538`](rustsec/advisory-db@c649f53) Assign RUSTSEC-2020-0022 to ozone ([RustSec/advisory-db⁠#329](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/329))
* [`6b56bccc`](rustsec/advisory-db@6b56bcc) Assign RUSTSEC IDs
* [`6b10ce09`](rustsec/advisory-db@6b10ce0) Update yaml-rust advirsory to indicate clap as non-vulnerable ([RustSec/advisory-db⁠#331](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/331))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants