-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dfinity dependency #306
Conversation
pikajude
commented
Jan 10, 2020
- See https://github.com/dfinity-lab/dfinity/pull/2137/files. This bundles Apple ld with the ic-client and drun packages
* See https://github.com/dfinity-lab/dfinity/pull/2137/files. This bundles Apple ld with the ic-client and drun packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'll let the SDK team be the judge of this
@pikajude Change this to ready for review if it is ready to review 😃 |
@pikajude I am doing an encoding change and update in a separate PR. We are in the process of making fixes related to id encodings (which breaks userlibrary which is not tested here). |
Ok, thanks @eftychis |
What’s the relation between this and #306? |
@nomeata I think you've the the PR/issue number wrong! |
Looks like the reflexivity relation. :-) |
Guess I meant #315 |
I think I updated this already to a later master. Closing this (if you think this is a mistake please reopen or make a new PR). |
## Changelog for advisory-db: Branch: Commits: [rustsec/advisory-db@aa789b9c...6b10ce09](rustsec/advisory-db@aa789b9...6b10ce0) * [`cff4f820`](rustsec/advisory-db@cff4f82) warn about CVE-2020-1967 * [`b0bc62bd`](rustsec/advisory-db@b0bc62b) Add `cargo-deny` to the list RustSec clients * [`e44e26f3`](rustsec/advisory-db@e44e26f) Assign RUSTSEC-2020-0015 to openssl-src * [`b1d3a5e7`](rustsec/advisory-db@b1d3a5e) Advisory for rio * [`25f622ba`](rustsec/advisory-db@25f622b) tempdir crate has been deprecated since 2018-02-13. * [`a3c68605`](rustsec/advisory-db@a3c6860) net2 crate has been deprecated; use socket2 instead * [`1639be65`](rustsec/advisory-db@1639be6) Assign RUSTSEC-2020-0016 to net2 * [`7d4ce9ae`](rustsec/advisory-db@7d4ce9a) Assign RUSTSEC-2018-0017 to tempdir * [`0f5a2dc2`](rustsec/advisory-db@0f5a2dc) Add advisory for internment ([RustSec/advisory-db#306](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/306)) * [`8587ec25`](rustsec/advisory-db@8587ec2) Assign RUSTSEC-2020-0017 to internment ([RustSec/advisory-db#309](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/309)) * [`5049594b`](rustsec/advisory-db@5049594) Add unmaintained crate advisory for `block-cipher-trait` (RUSTSEC-2020-0018) ([RustSec/advisory-db#310](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/310)) * [`ae22eb47`](rustsec/advisory-db@ae22eb4) CONTRIBUTING: mention soundness issues ([RustSec/advisory-db#314](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/314)) * [`7c96397e`](rustsec/advisory-db@7c96397) Security advisory for AtheMathmo/rulinalg[RustSec/advisory-db#201](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/201) * [`8149410e`](rustsec/advisory-db@8149410) Fix toml format error * [`45495b76`](rustsec/advisory-db@45495b7) .github: bump rustsec-admin cache key ([RustSec/advisory-db#321](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/321)) * [`418954a9`](rustsec/advisory-db@418954a) Create github action to assign RUSTSEC ids ([RustSec/advisory-db#311](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/311)) * [`48c86534`](rustsec/advisory-db@48c8653) Attempt to fix failing assign-ids task ([RustSec/advisory-db#322](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/322)) * [`de07a7d2`](rustsec/advisory-db@de07a7d) Add tokio-rustls DoS advisory ([RustSec/advisory-db#304](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/304)) * [`46c23f6c`](rustsec/advisory-db@46c23f6) Assign RUSTSEC IDs ([RustSec/advisory-db#323](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/323)) * [`9cd619f1`](rustsec/advisory-db@9cd619f) make memoffset advisory informational ([RustSec/advisory-db#317](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/317)) * [`1dfcb1d6`](rustsec/advisory-db@1dfcb1d) .github: lint advisories after assigning ID ([RustSec/advisory-db#324](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/324)) * [`6e2241c0`](rustsec/advisory-db@6e2241c) stb_truetype crate has been deprecated; use ttf-parser instead ([RustSec/advisory-db#307](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/307)) * [`07ae3fb2`](rustsec/advisory-db@07ae3fb) Assign RUSTSEC IDs ([RustSec/advisory-db#325](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/325)) * [`49fcc50d`](rustsec/advisory-db@49fcc50) Reflect PR feedback and describe what might happen * [`297725a1`](rustsec/advisory-db@297725a) README.md: bump maintained quarter comment * [`73b40e7d`](rustsec/advisory-db@73b40e7) Assign RUSTSEC IDs ([RustSec/advisory-db#326](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/326)) * [`ee09393d`](rustsec/advisory-db@ee09393) Security advisory for bqv/ozone * [`c649f538`](rustsec/advisory-db@c649f53) Assign RUSTSEC-2020-0022 to ozone ([RustSec/advisory-db#329](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/329)) * [`6b56bccc`](rustsec/advisory-db@6b56bcc) Assign RUSTSEC IDs * [`6b10ce09`](rustsec/advisory-db@6b10ce0) Update yaml-rust advirsory to indicate clap as non-vulnerable ([RustSec/advisory-db#331](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/331))
## Changelog for advisory-db: Branch: Commits: [rustsec/advisory-db@aa789b9c...6b10ce09](rustsec/advisory-db@aa789b9...6b10ce0) * [`cff4f820`](rustsec/advisory-db@cff4f82) warn about CVE-2020-1967 * [`b0bc62bd`](rustsec/advisory-db@b0bc62b) Add `cargo-deny` to the list RustSec clients * [`e44e26f3`](rustsec/advisory-db@e44e26f) Assign RUSTSEC-2020-0015 to openssl-src * [`b1d3a5e7`](rustsec/advisory-db@b1d3a5e) Advisory for rio * [`25f622ba`](rustsec/advisory-db@25f622b) tempdir crate has been deprecated since 2018-02-13. * [`a3c68605`](rustsec/advisory-db@a3c6860) net2 crate has been deprecated; use socket2 instead * [`1639be65`](rustsec/advisory-db@1639be6) Assign RUSTSEC-2020-0016 to net2 * [`7d4ce9ae`](rustsec/advisory-db@7d4ce9a) Assign RUSTSEC-2018-0017 to tempdir * [`0f5a2dc2`](rustsec/advisory-db@0f5a2dc) Add advisory for internment ([RustSec/advisory-db#306](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/306)) * [`8587ec25`](rustsec/advisory-db@8587ec2) Assign RUSTSEC-2020-0017 to internment ([RustSec/advisory-db#309](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/309)) * [`5049594b`](rustsec/advisory-db@5049594) Add unmaintained crate advisory for `block-cipher-trait` (RUSTSEC-2020-0018) ([RustSec/advisory-db#310](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/310)) * [`ae22eb47`](rustsec/advisory-db@ae22eb4) CONTRIBUTING: mention soundness issues ([RustSec/advisory-db#314](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/314)) * [`7c96397e`](rustsec/advisory-db@7c96397) Security advisory for AtheMathmo/rulinalg[RustSec/advisory-db#201](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/201) * [`8149410e`](rustsec/advisory-db@8149410) Fix toml format error * [`45495b76`](rustsec/advisory-db@45495b7) .github: bump rustsec-admin cache key ([RustSec/advisory-db#321](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/321)) * [`418954a9`](rustsec/advisory-db@418954a) Create github action to assign RUSTSEC ids ([RustSec/advisory-db#311](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/311)) * [`48c86534`](rustsec/advisory-db@48c8653) Attempt to fix failing assign-ids task ([RustSec/advisory-db#322](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/322)) * [`de07a7d2`](rustsec/advisory-db@de07a7d) Add tokio-rustls DoS advisory ([RustSec/advisory-db#304](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/304)) * [`46c23f6c`](rustsec/advisory-db@46c23f6) Assign RUSTSEC IDs ([RustSec/advisory-db#323](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/323)) * [`9cd619f1`](rustsec/advisory-db@9cd619f) make memoffset advisory informational ([RustSec/advisory-db#317](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/317)) * [`1dfcb1d6`](rustsec/advisory-db@1dfcb1d) .github: lint advisories after assigning ID ([RustSec/advisory-db#324](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/324)) * [`6e2241c0`](rustsec/advisory-db@6e2241c) stb_truetype crate has been deprecated; use ttf-parser instead ([RustSec/advisory-db#307](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/307)) * [`07ae3fb2`](rustsec/advisory-db@07ae3fb) Assign RUSTSEC IDs ([RustSec/advisory-db#325](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/325)) * [`49fcc50d`](rustsec/advisory-db@49fcc50) Reflect PR feedback and describe what might happen * [`297725a1`](rustsec/advisory-db@297725a) README.md: bump maintained quarter comment * [`73b40e7d`](rustsec/advisory-db@73b40e7) Assign RUSTSEC IDs ([RustSec/advisory-db#326](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/326)) * [`ee09393d`](rustsec/advisory-db@ee09393) Security advisory for bqv/ozone * [`c649f538`](rustsec/advisory-db@c649f53) Assign RUSTSEC-2020-0022 to ozone ([RustSec/advisory-db#329](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/329)) * [`6b56bccc`](rustsec/advisory-db@6b56bcc) Assign RUSTSEC IDs * [`6b10ce09`](rustsec/advisory-db@6b10ce0) Update yaml-rust advirsory to indicate clap as non-vulnerable ([RustSec/advisory-db#331](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/331))
## Changelog for advisory-db: Branch: Commits: [rustsec/advisory-db@aa789b9c...6b10ce09](rustsec/advisory-db@aa789b9...6b10ce0) * [`cff4f820`](rustsec/advisory-db@cff4f82) warn about CVE-2020-1967 * [`b0bc62bd`](rustsec/advisory-db@b0bc62b) Add `cargo-deny` to the list RustSec clients * [`e44e26f3`](rustsec/advisory-db@e44e26f) Assign RUSTSEC-2020-0015 to openssl-src * [`b1d3a5e7`](rustsec/advisory-db@b1d3a5e) Advisory for rio * [`25f622ba`](rustsec/advisory-db@25f622b) tempdir crate has been deprecated since 2018-02-13. * [`a3c68605`](rustsec/advisory-db@a3c6860) net2 crate has been deprecated; use socket2 instead * [`1639be65`](rustsec/advisory-db@1639be6) Assign RUSTSEC-2020-0016 to net2 * [`7d4ce9ae`](rustsec/advisory-db@7d4ce9a) Assign RUSTSEC-2018-0017 to tempdir * [`0f5a2dc2`](rustsec/advisory-db@0f5a2dc) Add advisory for internment ([RustSec/advisory-db#306](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/306)) * [`8587ec25`](rustsec/advisory-db@8587ec2) Assign RUSTSEC-2020-0017 to internment ([RustSec/advisory-db#309](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/309)) * [`5049594b`](rustsec/advisory-db@5049594) Add unmaintained crate advisory for `block-cipher-trait` (RUSTSEC-2020-0018) ([RustSec/advisory-db#310](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/310)) * [`ae22eb47`](rustsec/advisory-db@ae22eb4) CONTRIBUTING: mention soundness issues ([RustSec/advisory-db#314](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/314)) * [`7c96397e`](rustsec/advisory-db@7c96397) Security advisory for AtheMathmo/rulinalg[RustSec/advisory-db#201](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/201) * [`8149410e`](rustsec/advisory-db@8149410) Fix toml format error * [`45495b76`](rustsec/advisory-db@45495b7) .github: bump rustsec-admin cache key ([RustSec/advisory-db#321](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/321)) * [`418954a9`](rustsec/advisory-db@418954a) Create github action to assign RUSTSEC ids ([RustSec/advisory-db#311](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/311)) * [`48c86534`](rustsec/advisory-db@48c8653) Attempt to fix failing assign-ids task ([RustSec/advisory-db#322](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/322)) * [`de07a7d2`](rustsec/advisory-db@de07a7d) Add tokio-rustls DoS advisory ([RustSec/advisory-db#304](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/304)) * [`46c23f6c`](rustsec/advisory-db@46c23f6) Assign RUSTSEC IDs ([RustSec/advisory-db#323](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/323)) * [`9cd619f1`](rustsec/advisory-db@9cd619f) make memoffset advisory informational ([RustSec/advisory-db#317](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/317)) * [`1dfcb1d6`](rustsec/advisory-db@1dfcb1d) .github: lint advisories after assigning ID ([RustSec/advisory-db#324](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/324)) * [`6e2241c0`](rustsec/advisory-db@6e2241c) stb_truetype crate has been deprecated; use ttf-parser instead ([RustSec/advisory-db#307](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/307)) * [`07ae3fb2`](rustsec/advisory-db@07ae3fb) Assign RUSTSEC IDs ([RustSec/advisory-db#325](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/325)) * [`49fcc50d`](rustsec/advisory-db@49fcc50) Reflect PR feedback and describe what might happen * [`297725a1`](rustsec/advisory-db@297725a) README.md: bump maintained quarter comment * [`73b40e7d`](rustsec/advisory-db@73b40e7) Assign RUSTSEC IDs ([RustSec/advisory-db#326](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/326)) * [`ee09393d`](rustsec/advisory-db@ee09393) Security advisory for bqv/ozone * [`c649f538`](rustsec/advisory-db@c649f53) Assign RUSTSEC-2020-0022 to ozone ([RustSec/advisory-db#329](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/329)) * [`6b56bccc`](rustsec/advisory-db@6b56bcc) Assign RUSTSEC IDs * [`6b10ce09`](rustsec/advisory-db@6b10ce0) Update yaml-rust advirsory to indicate clap as non-vulnerable ([RustSec/advisory-db#331](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/331))
## Changelog for common: Branch: master Commits: [dfinity-lab/[email protected]](https://github.com/dfinity-lab/common/compare/65e45e53d7aa2d0d4f97808a97a2b6eb35d0cd01...6d6f00b54b348ad78bdc6d4e50d995a0557f35d8) * [`6d6f00b5`](https://github.com/dfinity-lab/common/commit/6d6f00b54b348ad78bdc6d4e50d995a0557f35d8) niv cargo2nix: update 5b2fc62a -> 62afa7a1 ([dfinity-lab/common#306](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/306))
## Changelog for common: Branch: master Commits: [dfinity-lab/[email protected]](https://github.com/dfinity-lab/common/compare/65e45e53d7aa2d0d4f97808a97a2b6eb35d0cd01...6d6f00b54b348ad78bdc6d4e50d995a0557f35d8) * [`6d6f00b5`](https://github.com/dfinity-lab/common/commit/6d6f00b54b348ad78bdc6d4e50d995a0557f35d8) niv cargo2nix: update 5b2fc62a -> 62afa7a1 ([dfinity-lab/common#306](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/306))