Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update django 4.2 support #176

Closed
wants to merge 1 commit into from
Closed

Conversation

irtazaakram
Copy link

Hi,

I've made this PR that

Can we also have a new release if this PR is merged?

Thanks,

Ref: edx/upgrades#310

@dfunckt
Copy link
Owner

dfunckt commented Jul 19, 2023

Hi, thanks for the PR. Why drop tests for Pypy?

@irtazaakram
Copy link
Author

irtazaakram commented Jul 21, 2023

Hi @dfunckt,

Coverage seems to not work with pypy3. I kept getting this error

pypy3-django32 run-test: commands[0] | coverage run tests/manage.py test testsuite -v 2
Traceback (most recent call last):
  File "/home/runner/work/django-rules/django-rules/tests/manage.py", line 8, in <module>
    from django.core.management import execute_from_command_line
  File "/home/runner/work/django-rules/django-rules/.tox/pypy3-django32/lib/pypy3.9/site-packages/django/core/management/__init__.py", line 13, in <module>
    from django.apps import apps
  File "/home/runner/work/django-rules/django-rules/.tox/pypy3-django32/lib/pypy3.9/site-packages/django/apps/__init__.py", line 1, in <module>
    from .config import AppConfig
  File "/home/runner/work/django-rules/django-rules/.tox/pypy3-django32/lib/pypy3.9/site-packages/django/apps/config.py", line 7, in <module>
    from django.utils.deprecation import RemovedInDjango41Warning
  File "/home/runner/work/django-rules/django-rules/.tox/pypy3-django32/lib/pypy3.9/site-packages/django/utils/deprecation.py", line 5, in <module>
    from asgiref.sync import sync_to_async
  File "/home/runner/work/django-rules/django-rules/.tox/pypy3-django32/lib/pypy3.9/site-packages/asgiref/sync.py", line 130, in <module>
    class AsyncToSync(Generic[_P, _R]):
  File "/opt/hostedtoolcache/PyPy/3.9.17/x64/lib/pypy3.9/typing.py", line 277, in inner
    return func(*args, **kwds)
  File "/opt/hostedtoolcache/PyPy/3.9.17/x64/lib/pypy3.9/typing.py", line 997, in __class_getitem__
    raise TypeError(
TypeError: Parameters to Generic[...] must all be type variables

Couldn't found any workaround for this.

I can add back tests if we can avoid coverage with pypy3

[testenv:pypy3]
commands =
    {envpython} tests/manage.py test testsuite {posargs: -v 2}

Let me know your thoughts on this.

@Zerotask
Copy link

Zerotask commented Jan 13, 2024

Since Django 5.0 was released a month ago, would it make sense to also add support for it with this? same with Python 3.12

@georgek
Copy link
Contributor

georgek commented Jan 17, 2024

Submitted #179 which supersedes this, includes Django 5.0 , Python 3.12 and doesn't disable pypy tests.

@federicobond
Copy link
Collaborator

Closing this in favor of #179. Big thanks to everyone involved! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants