Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install py.typed file so mypy will use included type defs #177

Closed
wants to merge 1 commit into from

Conversation

bradenmacdonald
Copy link
Contributor

I have rules==3.3 installed from pypi, but when I try to run type checks on a project that uses it, mypy reports this error:

my/project/rules.py:6: error: Skipping analyzing "rules": module is installed, but missing library stubs or py.typed marker  [import]

I believe the reason is that the py.typed file is not marked as package_data, so setuptools is not installing it. I think this should fix it.

@bradenmacdonald
Copy link
Contributor Author

Note: I am not sure why the pypy build is failing, but it's unrelated to this PR - see discussion on other PR.

@federicobond
Copy link
Collaborator

Thank you! Rebased and merged in #181, commit is still attributed to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants