Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove fallback coordinate field (DHIS2-8165) #2575

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

turban
Copy link
Contributor

@turban turban commented Apr 24, 2023

This PR will temporarily remove the fallback coordinate field from the event layer dialog as it is not working properly: https://dhis2.atlassian.net/browse/DHIS2-8165?focusedCommentId=182171

These issues needs to be addressed before we can release the new component.

After this PR the fallback coordinate field is not shown:

Screenshot 2023-04-24 at 10 45 01

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Apr 24, 2023

🚀 Deployed on https://pr-2575--dhis2-maps.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify April 24, 2023 08:51 Inactive
@turban turban changed the title fix: remove fallback coordinate field fix: remove fallback coordinate field (DHIS2-8165) Apr 24, 2023
@turban turban requested a review from jenniferarnesen April 24, 2023 09:04
@dhis2-bot dhis2-bot temporarily deployed to netlify April 24, 2023 09:11 Inactive
@cypress
Copy link

cypress bot commented Apr 24, 2023

Passing run #1978 ↗︎

0 33 20 0 Flakiness 0

Details:

Merge a767636 into b971e40...
Project: maps Commit: 2773178445 ℹ️
Status: Passed Duration: 03:54 💡
Started: Apr 24, 2023 11:10 AM Ended: Apr 24, 2023 11:14 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@turban turban merged commit d157c30 into dev Apr 24, 2023
@turban turban deleted the fix/fallback-coordinate-field-removal branch April 24, 2023 12:04
dhis2-bot added a commit that referenced this pull request May 16, 2023
# [100.1.0](v100.0.0...v100.1.0) (2023-05-16)

### Bug Fixes

* bumps cli-app-scripts to 10.3.8 for LIBS-499 fix ([#2592](#2592)) ([f305dc9](f305dc9))
* remove fallback coordinate field (DHIS2-8165) ([#2575](#2575)) ([e794125](e794125))

### Features

* **plugin:** send installation status [DHIS2-15097] ([#2580](#2580)) ([0817420](0817420))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants