Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove fallback coordinate field (DHIS2-8165, v40 backport) #2577

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

turban
Copy link
Contributor

@turban turban commented Apr 24, 2023

This PR will temporarily remove the fallback coordinate field from the event layer dialog as it is not working properly: https://dhis2.atlassian.net/browse/DHIS2-8165?focusedCommentId=182171

v40 backport of #2575

These issues need to be addressed before we can release the new component.

After this PR the fallback coordinate field is not shown:

Screenshot 2023-04-24 at 10 45 01

Before:

Screenshot 2023-04-24 at 10 47 46

@turban turban requested a review from jenniferarnesen April 24, 2023 10:05
@cypress
Copy link

cypress bot commented Apr 24, 2023

Passing run #1975 ↗︎

0 33 20 0 Flakiness 0

Details:

fix: remove fallback coordinate field
Project: maps Commit: cf36515e64
Status: Passed Duration: 04:14 💡
Started: Apr 24, 2023 10:11 AM Ended: Apr 24, 2023 10:15 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@turban turban merged commit ebd2f29 into v40 Apr 24, 2023
@turban turban deleted the fix/fallback-coordinate-field-removal-v40 branch April 24, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants